-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Dma stm32 fix #8579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dma stm32 fix #8579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8579 +/- ##
=======================================
Coverage 64.17% 64.17%
=======================================
Files 429 429
Lines 41157 41157
Branches 6925 6925
=======================================
Hits 26413 26413
Misses 11587 11587
Partials 3157 3157Continue to review full report at Codecov.
|
|
recheck |
|
@SebastianBoe |
The Transfer Complete (TC) interrupt as well as the Memory Increment (MINC) bits were not enabled for Periperal To Memory (and Memory to Peripheral) case. Signed-off-by: Armando Visconti <armando.visconti@st.com>
The DMA API provides dma_slot field as a method to configure at runtime which peripheral DMA_request the DMA controller should select. This method allows to specify different selections for different stm32 DMA streams. So, all the Kconfig definitions, which by the way where fixing the same selection for all DMA streams, have been deleted. Signed-off-by: Armando Visconti <armando.visconti@st.com>
|
Ok, sanitycheck is passed and bug has been closed. If it happens again I will re-open it. |
|
@erwango |
erwango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Can you confirm that tests/drivers/dma is still 'passed' with this change?
(requires to change DMA_DEVICE_NAME to "DMA_2")
Actually I don't know. How can I check it? |
|
@avisconti : Then (if you're interested), maybe would be worth to get some STM32 targets running this test in CI, btw... |
OK, got it.
I had also to add in prj.conf the following After that I launched the test on my ArgonKey and it worked: ***** Booting Zephyr OS v1.12.0-453-g286bd85 ***** |
|
@erwango To really test the commits I used the I2S driver I'm writing and tested it on ArgonKey. I tested it in both directions using I2S RX (from Microphone) and I2S TX on 96 board connector watching the transactions with a scope. |
|
@erwango |
(FIX for STM32 DMA)
I noticed that the STM32 DMA is not used much inside zephyr, expecially the memory-to-peripheral and peripherl-to-memory part. I'm currently implementing the stm32-i2s driver and I'm using the DMA for that purpose. My intention is to use it also inside SPI driver and maybe others.