tests: kconfig: cmake: Disable USERSPACE when using LINKER_GENERATOR #85075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RATOR Currently the CMAKE_LINKER_GENERATOR does not support CONFIG_USERSPACE. This will disable tests and the ability to enable CONFIG_USERSPACE when CMAKE_LINKER_GENERATOR is enabled. Signed-off-by: Robin Kastberg <robin.kastberg@iar.com>
zephyrbot
requested review from
MaureenHelm,
aaronemassey,
asemjonovs,
bbolen,
carlocaione,
galak,
jeremybettis,
microbuilder,
nashif,
stephanosio,
wearyzen and
yperess
Contributor
|
Hi @RobinKastberg, if you plan to revert this when when IAR enables CMAKE_LINKER_GENERATOR, could you please create an issue and add a link to it in the commit? |
Contributor
Author
|
I will.. But there is a big risk like this won't be long-lived or relevant at all: |
wearyzen
approved these changes
Feb 10, 2025
Contributor
Author
|
This will need to be made IAR specific now since LD actually supports this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CMAKE_LINKER_GENERATOR does not support CONFIG_USERSPACE. see
zephyr/cmake/linker_script/arm/linker.cmake
Line 122 in 491bbcf
This change will disable tests and the ability to enable CONFIG_USERSPACE when CMAKE_LINKER_GENERATOR is enabled.
IAR is currently working on this feature, but currently this breaks a lot of tests and test filtering so this would still be nice.