Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: intel: ace: Fix intel_adsp power down issue when CONFIG_ADSP_POWER_DOWN_HPSRAM not defined #85068

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kartben
Copy link
Collaborator

@kartben kartben commented Feb 3, 2025

CONFIG_ADSP_POWER_DOWN_HPSRAM may not be defined (when it's "n") so update the code accordingly so that power_down() is called with correct parameters.

Fixes multiple CI tests failing in weekly run.

Simple repro:

west build -p auto -b intel_adsp/ace15_mtpm/sim samples/hello_world -- -DCONFIG_PM=y -DCONFIG_ADSP_POWER_DOWN_HPSRAM=n

Tests failing:

west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.cpp14 -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.cpp17 -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.cpp20 -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.cpp2A -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.cpp2B -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.cpp98 -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.minimal -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.newlib -i
west twister -p intel_adsp/ace15_mtpm/sim -s cpp.main.picolibc -i
west twister -p intel_adsp/ace15_mtpm/sim -s net.coap.server.common -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.cpp14 -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.cpp17 -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.cpp20 -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.cpp2A -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.cpp2B -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.cpp98 -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.minimal -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.newlib -i
west twister -p intel_adsp/ace15_mtpm -s cpp.main.picolibc -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.cpp14 -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.cpp17 -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.cpp20 -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.cpp2A -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.cpp2B -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.cpp98 -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.minimal -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.newlib -i
west twister -p intel_adsp/ace20_lnl/sim -s cpp.main.picolibc -i
west twister -p intel_adsp/ace20_lnl/sim -s net.coap.server.common -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.cpp14 -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.cpp17 -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.cpp20 -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.cpp2A -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.cpp2B -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.cpp98 -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.minimal -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.newlib -i
west twister -p intel_adsp/ace20_lnl -s cpp.main.picolibc -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.cpp14 -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.cpp17 -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.cpp20 -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.cpp2A -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.cpp2B -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.cpp98 -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.minimal -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.newlib -i
west twister -p intel_adsp/ace30/ptl/sim -s cpp.main.picolibc -i
west twister -p intel_adsp/ace30/ptl/sim -s net.coap.server.common -i
west twister -p intel_adsp/ace30/ptl/sim -s sample.audio.sof -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.cpp14 -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.cpp17 -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.cpp20 -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.cpp2A -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.cpp2B -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.cpp98 -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.minimal -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.newlib -i
west twister -p intel_adsp/ace30/ptl -s cpp.main.picolibc -i

CONFIG_ADSP_POWER_DOWN_HPSRAM may not be defined (when it's "n") so
update the code accordingly so that power_down() is called with
correct parameters.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben changed the title soc: intel: ace: Fix intel_adsp power down issue w soc: intel: ace: Fix intel_adsp power down issue when CONFIG_ADSP_POWER_DOWN_HPSRAM not defined Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant