Skip to content

boards: up_squared: add timeout multiplier #80377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

arikgreen
Copy link
Contributor

@arikgreen arikgreen commented Oct 24, 2024

To accommodate for some slow tests on up2.
For example: tests/arch/x86/info/arch.x86.info.userspace
Execution time of this test is close to 55s and sometimes above up to the 60s.

Fixes #80134

@zephyrbot
Copy link

zephyrbot commented Oct 24, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nashif
Copy link
Member

nashif commented Oct 24, 2024

why does this behave differently on 3.7 branch?

@jukkar jukkar removed their request for review October 24, 2024 14:13
@arikgreen
Copy link
Contributor Author

why does this behave differently on 3.7 branch?

up2 behaves same as on main but on main it has set timeout_multiplier so we don't see failes
Execution time on main:

date test suite name test case name tc status tc execution time
Oct, 12 2024 tests/arch/x86/info/arch.x86.info arch.x86.info passed 56.94
  tests/arch/x86/info/arch.x86.info.userspace arch.x86.info.userspace passed 56.29
Oct, 23 2024 tests/arch/x86/info/arch.x86.info arch.x86.info passed 65.58
  tests/arch/x86/info/arch.x86.info.userspace arch.x86.info.userspace passed 56.65
Oct, 22 2024 tests/arch/x86/info/arch.x86.info arch.x86.info passed 63.02
  tests/arch/x86/info/arch.x86.info.userspace arch.x86.info.userspace passed 63.52
Oct, 21 2024 tests/arch/x86/info/arch.x86.info arch.x86.info passed 55.77
  tests/arch/x86/info/arch.x86.info.userspace arch.x86.info.userspace passed 55.75
Oct, 20 2024 tests/arch/x86/info/arch.x86.info arch.x86.info passed 55.58
  tests/arch/x86/info/arch.x86.info.userspace arch.x86.info.userspace passed 64.62

@nashif
Copy link
Member

nashif commented Oct 24, 2024

up2 behaves same as on main but on main it has set timeout_multiplier so we don't see failes
Execution time on main:

does it? looking at https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/up-bridge-the-gap/up_squared/up_squared.yaml it does not have a multiplier

@zephyrproject-rtos zephyrproject-rtos deleted a comment from arikgreen Oct 25, 2024
@nashif
Copy link
Member

nashif commented Oct 29, 2024

@arikgreen you need to submit this to main, and label it for backporting by the bot.

@arikgreen arikgreen force-pushed the arikgreen/fix-up2-timeout branch from 988d76f to acee1e1 Compare October 29, 2024 12:09
@arikgreen arikgreen requested a review from nandojve as a code owner October 29, 2024 12:09
@arikgreen arikgreen changed the base branch from v3.7-branch to main October 29, 2024 12:10
@arikgreen arikgreen added backport v3.7-branch Request backport to the v3.7-branch Backport Backport PR and backport failure issues and removed backport v3.7-branch Request backport to the v3.7-branch labels Oct 29, 2024
To accommodate for some slow tests on up2.
For example: tests/arch/x86/info/arch.x86.info.userspace
Execution time of this test is close to 55s and sometimes
above up to the 60s.
Related issue: zephyrproject-rtos#80134

Signed-off-by: Artur Wilczak <arturx.wilczak@intel.com>
@arikgreen arikgreen force-pushed the arikgreen/fix-up2-timeout branch from acee1e1 to db0081d Compare October 29, 2024 13:13
@nashif nashif added backport v3.7-branch Request backport to the v3.7-branch and removed Backport Backport PR and backport failure issues labels Oct 29, 2024
@nashif nashif requested review from teburd and dcpleung October 29, 2024 13:46
@nashif nashif self-assigned this Oct 29, 2024
@nashif nashif added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Oct 30, 2024
@mmahadevan108 mmahadevan108 merged commit 9cce72d into zephyrproject-rtos:main Oct 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v3.7-branch Request backport to the v3.7-branch size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[3.7] up_squared: tests/arch/x86/info/arch.x86.info.userspace [timeout]
7 participants