tests/ztest/fail: Fix unit_testing part #80283
Open
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use full board name in cmake file. Akin to the fix done in zephyrproject-rtos#80270 following the changes from zephyrproject-rtos#77250 Note after the Zephyr cmake code has been run the BOARD variable is split into BOARD BOARD_QUALIFIERS, where BOARD does not contain the qualifiers anymore (see cmake/modules/boards.cmake for more info). Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Fix filtering done in 22c3438 Otherwise we end up with tests defined twice, as a .unit and .zerphyr variant but both run in normal builds, and none for unit tests. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
zephyrbot
requested review from
aaronemassey,
asemjonovs,
jeremybettis,
nashif and
yperess
nordicjm
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR is not marked as a hotfix, as these tests are currently filtered out for
unit_testingand therefore cannot trigger in main.Related to