-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK_VERSION: Use Zephyr SDK 0.17.0 #80192
Open
stephanosio
wants to merge
5
commits into
zephyrproject-rtos:main
Choose a base branch
from
stephanosio:sdk-0.17.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+16
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Thrift module tests were under the "newlib" namespace, presumably because newlib was the default at the time of their introduction. Since newlib is no longer the default libc and Thrift is not being tested against multiple C libraries, this removes the libc type from the Thrift test identifiers. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
The Thrift library makes use of POSIX C functions such as ctime_r(), which are not part of the ISO C standard. This commit adds a Thrift module-wide `_POSIX_C_SOURCE` feature test macro definition in order to ensure that the required POSIX C functions are available when compiling the Thrift library. Note that this was not caught earlier because Newlib and older versions of Picolibc did not properly fence off some POSIX functions behind the feature test macros. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
This commit increases the test timeout for the wait queue benchmark tests to 120 seconds because these tests frequently hit the default timeout of 60 seconds during execution. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
This commit updates the CI workflows to use the CI image v0.27.3, which includes Zephyr SDK 0.17.0. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
This commit updates ZEPHYR_SDK to point to the Zephyr SDK 0.17.0 release. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
rruuaanng
approved these changes
Oct 22, 2024
dbaluta
approved these changes
Oct 22, 2024
zephyrbot
added
platform: nRF BSIM
Nordic Semiconductors, nRF BabbleSim
area: Thrift
Thrift RPC
area: Serialization
area: Continuous Integration
area: Benchmarks
labels
Oct 22, 2024
zephyrbot
requested review from
aescolar,
cfriedt,
dcpleung,
fabiobaltieri,
kartben,
nashif and
peter-mitsis
October 22, 2024 12:06
fabiobaltieri
approved these changes
Oct 22, 2024
45 tasks
aescolar
approved these changes
Oct 22, 2024
henrikbrixandersen
approved these changes
Oct 22, 2024
cfriedt
approved these changes
Oct 22, 2024
dcpleung
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Benchmarks
area: Continuous Integration
area: Serialization
area: Thrift
Thrift RPC
platform: nRF BSIM
Nordic Semiconductors, nRF BabbleSim
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Zephyr SDK 0.17.0 in the CI workflows
This series includes the additional patches required to resolve compatibility issues with the SDK 0.17.0 and Picolibc 1.8.8 release.
Includes commits from #79873
Tested in https://github.com/zephyrproject-rtos/zephyr-testing/actions/runs/11455539853
Note that "Run tests with twister" failure is expected in this PR because this workflow runs in the context of the base branch (
main
).