Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: bluetooth: Rename Silabs HCI driver #80155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhedberg
Copy link
Member

Rename the Silabs HCI driver to hci_silabs_efr32.c to better indicate what hardware it supports. Also rename the associated devicetree binding and Kconfig options to be consistent with the new driver name.

@jhedberg
Copy link
Member Author

Added the DNM flag, since this actually depends on an update to CMakeLists.txt in the HAL tree. I think it's better to wait for #80148 to be merged first since then it's the main tree modules/hal_silabs/simplicity_sdk/CMakeLists.txt that needs updating instead.

@jhedberg jhedberg added this to the v4.0.0 milestone Oct 21, 2024
Copy link
Contributor

@jerome-pouiller jerome-pouiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should rename the slz_ functions before to merge ths PR.

MAINTAINERS.yml Show resolved Hide resolved
drivers/bluetooth/hci/CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions in this file are prefixed with slz_. Maybe we could rename them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions in this file are prefixed with slz_. Maybe we could rename them?

Those functions are private to the driver, and I was trying to keep this PR as minimal as possible. The names can be changed at any point without affecting anything outside of the driver. What would you like the names to be? (I considered doing the rename but then dropped the idea since I couldn't decide on a nice and short prefix)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I foresee a long discussion. Let's postpone that change.

@Thalley Thalley removed their request for review October 21, 2024 15:48
asmellby
asmellby previously approved these changes Oct 21, 2024
Rename the Silabs HCI driver to hci_silabs_efr32.c to better indicate what
hardware it supports. Also rename the associated devicetree binding and
Kconfig options to be consistent with the new driver name.

Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
@jhedberg jhedberg removed the DNM This PR should not be merged (Do Not Merge) label Oct 22, 2024
@jhedberg
Copy link
Member Author

Added the DNM flag, since this actually depends on an update to CMakeLists.txt in the HAL tree. I think it's better to wait for #80148 to be merged first since then it's the main tree modules/hal_silabs/simplicity_sdk/CMakeLists.txt that needs updating instead.

Rebased now and DNM label removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants