Skip to content

NXP S32 introduce support SENT #80117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

congnguyenhuu
Copy link
Collaborator

@congnguyenhuu congnguyenhuu commented Oct 21, 2024

Introduce support Single Edge Nibble Transmission (SENT) driver using peripheral SENT receiver on S32Z. This driver allows to communication (read data) with SENT device.
The test result: SENT-RECEIVER-TESTING-RESULT.pptx

RFC: #83983

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 21, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@d0e49d6 zephyrproject-rtos/hal_nxp#455 zephyrproject-rtos/hal_nxp#455/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 21, 2024
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 4 times, most recently from ec62630 to b483917 Compare October 28, 2024 03:29
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 3 times, most recently from d00b883 to 23b01d3 Compare November 1, 2024 02:24
@congnguyenhuu congnguyenhuu marked this pull request as ready for review November 22, 2024 03:42
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 23b01d3 to 55d6a35 Compare November 22, 2024 03:42
@zephyrbot zephyrbot added platform: NXP S32 NXP Semiconductors, S32 area: Samples Samples labels Nov 22, 2024
@manuargue
Copy link
Member

@congnguyenhuu I'd suggest you to open an RFC (request for comments) and link it to this pr in order to involve community to review the proposal and reach consensus: https://docs.zephyrproject.org/latest/contribute/proposals_and_rfcs.html

@congnguyenhuu congnguyenhuu marked this pull request as draft November 22, 2024 04:32
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 55d6a35 to ec00dc8 Compare December 4, 2024 07:52
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 5 times, most recently from c79ca4d to f2e3c0c Compare January 7, 2025 01:54
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 2a89422 to 274957a Compare May 5, 2025 06:41
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 274957a to 4af1b4e Compare May 6, 2025 11:13
@kartben kartben requested a review from Copilot May 6, 2025 11:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces support for the SENT driver using the peripheral SENT receiver on S32Z hardware. Key changes include adding new dt-binding macros and YAML files for SENT configuration, developing a dedicated SENT driver API with callback registration, and updating board and MAINTAINERS files to integrate and support the new driver.

Reviewed Changes

Copilot reviewed 21 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
include/zephyr/dt-bindings/saej2716/saej2716.h Added macro definitions for CRC and binding constants
include/zephyr/drivers/saej2716/saej2716.h Introduced the SENT driver API and callback definitions
dts/bindings/saej2716/saej2716-controller.yaml Defined YAML configurations for the SENT controller binding
dts/bindings/saej2716/nxp,s32-saej2716.yaml Provided YAML for SENT receiver controller configuration
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu1_D.yaml Updated board configuration to include support for saej2716
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu1.yaml Updated board configuration to include support for saej2716
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu0_D.yaml Updated board configuration to include support for saej2716
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu0.yaml Updated board configuration to include support for saej2716
MAINTAINERS.yml Added maintainer and collaborator details along with relevant labels
Files not reviewed (11)
  • doc/hardware/peripherals/index.rst: Language not supported
  • doc/hardware/peripherals/saej2716.rst: Language not supported
  • drivers/CMakeLists.txt: Language not supported
  • drivers/Kconfig: Language not supported
  • drivers/saej2716/CMakeLists.txt: Language not supported
  • drivers/saej2716/Kconfig: Language not supported
  • drivers/saej2716/Kconfig.nxp_s32: Language not supported
  • dts/arm/nxp/nxp_s32z27x_r52.dtsi: Language not supported
  • samples/drivers/saej2716/CMakeLists.txt: Language not supported
  • samples/drivers/saej2716/README.rst: Language not supported
  • samples/drivers/saej2716/boards/s32z2xxdc2_s32z270_rtu0.overlay: Language not supported
Comments suppressed due to low confidence (1)

include/zephyr/drivers/saej2716/saej2716.h:78

  • [nitpick] Consider renaming the parameter 'num_frame' to 'num_frames' to better reflect that it represents a count.
enum saej2716_status status, uint32_t num_frame,

@congnguyenhuu
Copy link
Collaborator Author

I have updated to the v2 changes:

  • combined property crc-status-nibble-include to property fast-crc due to this only apply for fast frame CRC
  • Added require true for mandatory properties

@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 2 times, most recently from 2e33c87 to 19da437 Compare May 13, 2025 02:36
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 19da437 to 3229101 Compare May 19, 2025 06:20
@congnguyenhuu
Copy link
Collaborator Author

I have updated to the v3 changes: added the check for the valid value of the binding properties fast-crc and short-serial-crc

@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 3229101 to f94af79 Compare May 22, 2025 02:09
Dat-NguyenDuy
Dat-NguyenDuy previously approved these changes May 22, 2025
Copy link
Collaborator

@Dat-NguyenDuy Dat-NguyenDuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from my side

manuargue
manuargue previously approved these changes May 22, 2025
@@ -2039,6 +2039,23 @@ Release Notes:
tests:
- drivers.pwm

"Drivers: SAEJ2716":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't it called SNET?

Copy link
Member

@manuargue manuargue May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the ambiguity of the previously proposed API names in #80117 (comment) -it was something like sent_rx_- and one of the proposals that was picked is to use the standard name as a prefix, similarly as done with IEEE802154, IEEE80211*. Although it removes the ambiguety, I acknowledge this protocol is more commonly known as SENT.

rruuaanng
rruuaanng previously approved these changes May 23, 2025
@manuargue
Copy link
Member

hi @carlescufi , @henrikbrixandersen . Can we remove the architecture review label or is there anything else to discuss? Thanks

…iver

This driver allows to communication (receive data) with SENT device

Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
enable support SAEJ2716 SENT

Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
Create test, sample for saej2716 driver

Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
@congnguyenhuu congnguyenhuu dismissed stale reviews from rruuaanng, manuargue, and Dat-NguyenDuy via f46b2c9 May 28, 2025 04:19
@congnguyenhuu congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from f94af79 to f46b2c9 Compare May 28, 2025 04:19
Copy link

@carlescufi carlescufi removed the Architecture Review Discussion in the Architecture WG required label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree area: Process area: Samples Samples DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_nxp platform: NXP S32 NXP Semiconductors, S32 RFC Request For Comments: want input from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants