-
Notifications
You must be signed in to change notification settings - Fork 7.4k
NXP S32 introduce support SENT #80117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NXP S32 introduce support SENT #80117
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
ec62630
to
b483917
Compare
d00b883
to
23b01d3
Compare
23b01d3
to
55d6a35
Compare
@congnguyenhuu I'd suggest you to open an RFC (request for comments) and link it to this pr in order to involve community to review the proposal and reach consensus: https://docs.zephyrproject.org/latest/contribute/proposals_and_rfcs.html |
55d6a35
to
ec00dc8
Compare
c79ca4d
to
f2e3c0c
Compare
2a89422
to
274957a
Compare
274957a
to
4af1b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces support for the SENT driver using the peripheral SENT receiver on S32Z hardware. Key changes include adding new dt-binding macros and YAML files for SENT configuration, developing a dedicated SENT driver API with callback registration, and updating board and MAINTAINERS files to integrate and support the new driver.
Reviewed Changes
Copilot reviewed 21 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
include/zephyr/dt-bindings/saej2716/saej2716.h | Added macro definitions for CRC and binding constants |
include/zephyr/drivers/saej2716/saej2716.h | Introduced the SENT driver API and callback definitions |
dts/bindings/saej2716/saej2716-controller.yaml | Defined YAML configurations for the SENT controller binding |
dts/bindings/saej2716/nxp,s32-saej2716.yaml | Provided YAML for SENT receiver controller configuration |
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu1_D.yaml | Updated board configuration to include support for saej2716 |
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu1.yaml | Updated board configuration to include support for saej2716 |
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu0_D.yaml | Updated board configuration to include support for saej2716 |
boards/nxp/s32z2xxdc2/s32z2xxdc2_s32z270_rtu0.yaml | Updated board configuration to include support for saej2716 |
MAINTAINERS.yml | Added maintainer and collaborator details along with relevant labels |
Files not reviewed (11)
- doc/hardware/peripherals/index.rst: Language not supported
- doc/hardware/peripherals/saej2716.rst: Language not supported
- drivers/CMakeLists.txt: Language not supported
- drivers/Kconfig: Language not supported
- drivers/saej2716/CMakeLists.txt: Language not supported
- drivers/saej2716/Kconfig: Language not supported
- drivers/saej2716/Kconfig.nxp_s32: Language not supported
- dts/arm/nxp/nxp_s32z27x_r52.dtsi: Language not supported
- samples/drivers/saej2716/CMakeLists.txt: Language not supported
- samples/drivers/saej2716/README.rst: Language not supported
- samples/drivers/saej2716/boards/s32z2xxdc2_s32z270_rtu0.overlay: Language not supported
Comments suppressed due to low confidence (1)
include/zephyr/drivers/saej2716/saej2716.h:78
- [nitpick] Consider renaming the parameter 'num_frame' to 'num_frames' to better reflect that it represents a count.
enum saej2716_status status, uint32_t num_frame,
I have updated to the v2 changes:
|
2e33c87
to
19da437
Compare
19da437
to
3229101
Compare
I have updated to the v3 changes: added the check for the valid value of the binding properties |
3229101
to
f94af79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine from my side
@@ -2039,6 +2039,23 @@ Release Notes: | |||
tests: | |||
- drivers.pwm | |||
|
|||
"Drivers: SAEJ2716": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't it called SNET?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented on the ambiguity of the previously proposed API names in #80117 (comment) -it was something like sent_rx_
- and one of the proposals that was picked is to use the standard name as a prefix, similarly as done with IEEE802154, IEEE80211*. Although it removes the ambiguety, I acknowledge this protocol is more commonly known as SENT
.
hi @carlescufi , @henrikbrixandersen . Can we remove the architecture review label or is there anything else to discuss? Thanks |
…iver This driver allows to communication (receive data) with SENT device Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
enable support SAEJ2716 SENT Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
Create test, sample for saej2716 driver Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
f46b2c9
f94af79
to
f46b2c9
Compare
|
Introduce support Single Edge Nibble Transmission (SENT) driver using peripheral SENT receiver on S32Z. This driver allows to communication (read data) with SENT device.
The test result: SENT-RECEIVER-TESTING-RESULT.pptx
RFC: #83983