bluetooth: shell: Fix includes #80105
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to build the shell with BT_CTLR_DTM and/or BT_CTLR_ADV_EXT enabled. The issues has been introduced by commit bf897cf (Bluetooth: Shell: Restructure shell files). Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
zephyrbot
requested review from
carlescufi,
cvinayak,
erbr-ot,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
cvinayak
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Question:
* For those two settings, would it be okay (tolerated? appreciated?) to add an an extra build in CI "just" to test whether enabling those flags does not break the build?
Please add a new tests target in testcases.yaml file with added extra_configs with CONFIG_BT_CTLR_DTM for nrf52840dk/nrf52840 board.
Using which board did you discover the issue?
| @@ -53,7 +53,7 @@ int cmd_ll_addr_read(const struct shell *sh, size_t argc, char *argv[]) | |||
| } | |||
|
|
|||
| #if defined(CONFIG_BT_CTLR_DTM) | |||
| #include "../controller/ll_sw/ll_test.h" | |||
| #include "../ll_test.h" | |||
There was a problem hiding this comment.
Suggested change
| #include "../ll_test.h" | |
| #include "controller/ll_sw/ll_test.h" |
| @@ -123,7 +123,7 @@ int cmd_test_end(const struct shell *sh, size_t argc, char *argv[]) | |||
| #endif /* CONFIG_BT_CTLR_DTM */ | |||
|
|
|||
| #if defined(CONFIG_BT_CTLR_ADV_EXT) | |||
| #include "controller/ll_sw/lll.h" | |||
| #include "../lll.h" | |||
There was a problem hiding this comment.
Suggested change
| #include "../lll.h" | |
| #include "controller/ll_sw/lll.h" |
cvinayak
added
bug
An nRF52840 (or maybe nRF54L15) based out-of-tree board. |
Any proposal on which Or did you mean to add a directory |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to build the shell with BT_CTLR_DTM and/or BT_CTLR_ADV_EXT enabled.
The issues has been introduced by commit
bf897cf (Bluetooth: Shell: Restructure shell files).
Question: