soc: kinetis: disable on reset NMI and EzPort #80062
Conversation
butok
commented
Oct 18, 2024
butok
commented
- Disables on reset NMI and EzPort.
- Fixes possible reset and power-on issues.
- Already applied for K64, now applying for the rest of Kinetis.
zephyrbot
requested review from
danieldegrasse,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
mmahadevan108 and
yvanderv
butok
force-pushed
the
fopt_kinetis_off_nmi
branch
from
0b1b1d5
to
10c6a68
Compare
| # 0000 0001 - Normal Boot | ||
| # 0000 0100 - Enable Interrupts | ||
| # 0000 1000 - Allow Reset detection from RESET_Pin | ||
| # 0111 0000 - Reserved for Future Expansion |
There was a problem hiding this comment.
Why remove the documentation here of how to use this option? Is it inaccurate?
There was a problem hiding this comment.
Why remove the documentation here of how to use this option? Is it inaccurate?
To be consistent across all SOCs, I only documented non-default/non-reset values.
Would you like to add documentation for default values as well?
BTW: I have feeling that it should be in DTS, instead of config.
It can be done in future, if really required.
There was a problem hiding this comment.
Sure, doing it via DTS might make sense. I'm just asking because it seems like this would be useful information for the user.
Adding documentation to all SOCs would be nice, but I don't want to increase the scope of the PR. I just want to avoid removing useful comments like these in the name of consistency across SOCs.
There was a problem hiding this comment.
We shouldn't remove the documentation unless it is incorrect. If we want to be consistent then lets add a ticket to add this type of documentation to the other platforms.
There was a problem hiding this comment.
We shouldn't remove the documentation unless it is incorrect. If we want to be consistent then lets add a ticket to add this type of documentation to the other platforms.
OK. The comment was updated with the default field definitions.
There was a problem hiding this comment.
Do we need to add something to the migration guide about these values changing? I know this seems odd, but we are effectively changing the boot configuration for the KE and K8 parts, right? Currently the KE1XF would boot from ROM when BOOTCFG0 is asserted, and with this change it no longer will. I think changing the default is ok, but users may be confused if they are currently using this feature and the functionality changes without much warning
Ping @henrikbrixandersen (since you are the user I'm thinking about here)
There was a problem hiding this comment.
I am not sure why this needs to be changed at all?
- Disables on reset NMI and EzPort. - Fixes possible reset and power-on issues. - Already applied for K64, now applying for the rest of Kinetis. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
butok
force-pushed
the
fopt_kinetis_off_nmi
branch
from
10c6a68
to
a63ade8
Compare
