Skip to content

Support Renesas RA GPIO interrupt #79849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thenguyenyf
Copy link
Contributor

@thenguyenyf thenguyenyf commented Oct 15, 2024

  • Add support for GPIO interrupt on Renesas RA family
  • Enable support of gpio-key for on-board buttons of Renesas RA boards
  • Move device node of ioport6, ioport7, ioport8 on r7fa6m4af3cfb to common part of r7fa6m4ax
  • Add 1 more whitespace sensitive macro for clang-format: DT_FOREACH_PROP_ELEM_SEP

@zephyrbot zephyrbot added platform: Renesas RA Renesas Electronics Corporation, RA area: Coding Guidelines Coding guidelines and style area: GPIO labels Oct 15, 2024
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch from cfd7dda to 6af191c Compare October 15, 2024 10:29
@keith-zephyr keith-zephyr assigned soburi and unassigned keith-zephyr Oct 21, 2024
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch 2 times, most recently from 7cd4a9f to 54931aa Compare October 25, 2024 01:27
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch from 54931aa to afd21df Compare November 7, 2024 11:43
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch 2 times, most recently from c25ee03 to ce1e41d Compare November 25, 2024 06:42
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch 2 times, most recently from fbabf34 to 8ac8bcc Compare December 5, 2024 03:23
@thenguyenyf
Copy link
Contributor Author

Last push to rebase main branch and solve conflicts

soburi
soburi previously approved these changes Dec 6, 2024
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch from 8ac8bcc to ade296b Compare December 17, 2024 04:14
@thenguyenyf
Copy link
Contributor Author

Last push to rebase main and solve conflict

@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch from ade296b to 4137a9f Compare December 17, 2024 06:52
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is implemented correctly, but damn, is it complex :D I would add a doc entry somewhere to explain how it works with the ioports

duynguyenxa
duynguyenxa previously approved these changes Dec 18, 2024
soburi
soburi previously approved these changes Dec 18, 2024
@kartben
Copy link
Contributor

kartben commented Dec 18, 2024

needs a rebase

Move ioport6, ioport7, ioport8 to r7fa6m4ax due to it is common
part of RA6M4
Impacted file:
- dts/arm/renesas/ra/ra6/r7fa6m4ax.dtsi
- dts/arm/renesas/ra/ra6/r7fa6m4af3cfb.dtsi

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
First commit to add support for gpio interrupt on Renesas RA
- Add support for external interrupt driver
- Add support for gpio interrupt config

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add dts node to support for gpio interrupt on Renesas RA SoC
- Add external interrupt node
- Add gpio interrupt pins

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add gpio keys support for these boards: ek_ra2a1, ek_ra4e2, ek_ra4m2,
ek_ra4m3, ek_ra4w1, ek_ra6e2, ek_ra6m1, ek_ra6m2, ek_ra6m3, ek_ra6m4,
ek_ra6m5, ek_ra8d1, ek_ra8m1, fpb_ra6e1, fpb_ra6e2

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Prevent 'DT_FOREACH_PROP_ELEM_SEP' macro from being formatted

Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
@thenguyenyf thenguyenyf force-pushed the support_renesas_ra_gpio_interrupt branch from 4137a9f to 3fc2cbf Compare December 18, 2024 12:08
@kartben kartben merged commit 64492b6 into zephyrproject-rtos:main Dec 19, 2024
37 checks passed
@thenguyenyf thenguyenyf deleted the support_renesas_ra_gpio_interrupt branch February 4, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Coding Guidelines Coding guidelines and style area: GPIO platform: Renesas RA Renesas Electronics Corporation, RA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants