Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: i2c: tca9544a #79546

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FlorianWeber1018
Copy link
Contributor

Extend tca954x (tca9546a, tca9548a) driver to support tca9544a i2c MUX. (different bitmask and flag for enable bit in register)

@FlorianWeber1018 FlorianWeber1018 force-pushed the ti_tca9544a_driver_extension branch 3 times, most recently from 8b254a4 to 66e6f04 Compare October 9, 2024 09:24
@FlorianWeber1018 FlorianWeber1018 marked this pull request as ready for review October 9, 2024 12:53
@zephyrbot zephyrbot added platform: TI SimpleLink Texas Instruments SimpleLink MCU area: I2C labels Oct 9, 2024
@FlorianWeber1018
Copy link
Contributor Author

FlorianWeber1018 commented Oct 9, 2024

Tested only with tca9544a on real hardware, so it would be great if someone can test the implementation against tca9548 or tca9546. Or are the CI tests here sufficient?

Extend tca954x (tca9546a, tca9548a) driver to support tca9544a i2c MUX.
(different bitmask and flag for enable bit in register)

Signed-off-by: Florian Weber <Florian.Weber@live.de>
@FlorianWeber1018
Copy link
Contributor Author

FlorianWeber1018 commented Oct 17, 2024

I have now also tested with a tca9548a.
So from my perspective this PR is ready for review/merge

Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, author has noted successfully using the driver on hardware (I don't have this) so +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: I2C platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants