Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostap: add WPS PBC and PIN for AP mode #79540

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hostap: add WPS PBC and PIN for AP mode #79540

wants to merge 2 commits into from
+192 −4

Conversation

MaochenWang1
Copy link
Contributor

add WPS PBC and PIN for AP mode.

@MaochenWang1
Copy link
Contributor Author

Hi @jukkar @krish2718 please review

krish2718
krish2718 reviewed Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also maybe the file supp_api.c is becoming large, so, may be it's time to start adding supp_api_wps.c, supp_api_p2p.c etc?

modules/hostap/CMakeLists.txt Show resolved Hide resolved
include/zephyr/net/wifi_mgmt.h Outdated Show resolved Hide resolved
modules/hostap/src/supp_api.c Show resolved Hide resolved
krish2718
krish2718 previously approved these changes Oct 14, 2024
View reviewed changes
@MaochenWang1
Copy link
Contributor Author

MaochenWang1 commented Oct 15, 2024 •
edited
Loading

Hi @krish2718 @jukkar @dleach02 please review

@MaochenWang1
hostap: add WPS PBC and PIN for AP mode
271a5f7 
add WPS PBC and PIN for AP mode.

Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
@MaochenWang1
hostap: use the correct config for EAP_SERVER
dcf698b 
Should use EAP_SERVER and EAP_SERVER_IDENTITY as the correct config,
for the AP WPS case.

Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
@MaochenWang1
Copy link
Contributor Author

Hi @krish2718 @jukkar @dleach02 please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish2718 krish2718 krish2718 approved these changes

@jukkar jukkar Awaiting requested review from jukkar

@kartben kartben Awaiting requested review from kartben

@nashif nashif Awaiting requested review from nashif

@rlubos rlubos Awaiting requested review from rlubos

At least 2 approving reviews are required to merge this pull request.

Assignees

@jukkar jukkar

@krish2718 krish2718

Labels
area: Networking area: Samples Samples area: Wi-Fi Wi-Fi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaochenWang1 @krish2718 @jukkar @zephyrbot