llext: Shell sample fixups #79429
Draft
llext: Shell sample fixups #79429
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simple naming at this point is a bit understating what the test suite is attempting to validate, which is that we can load, link, and execute a variety of extensions under a variety of scenarios. Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
Hello world from the tests is not longer what it once was, a simple hello_world function that prints. The sample was here to let people explore and learn about how llext and ELFs work. Moving the sample extension code to the shell loader sample disconnects the two and lets the sample remain simpler. Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
|
Nice idea, appreciated! My 2c: I kind of regret pushing for creating the "simple" directory, since we have never found the need for a different test suite. Unless you already have ideas on that topic, we could remove the subfolder altogether and just have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple naming at this point is a bit understating what the test
suite is attempting to validate, which is that we can load, link, and
execute a variety of extensions under a variety of scenarios.
Copies and modifies the hello_world sample extension for use with the
sample app.
TODO: Need to test this out and verify I can do things without needing EXPORT_SYMBOL, which apparently requires all of zephyr (ugh) to exist.
Fixes #79318