drivers: i2c: Introduce I2C timeout and bus recovery for SAM0 #79311
Conversation
zephyrbot
added
platform: Microchip SAM
zephyrbot
requested review from
attie-argentum,
mnkp,
nandojve,
pdgendt,
stephanosio and
teburd
Adds configurable timeout for I2C transactions and provides bus recovery functionality. Signed-off-by: Jan Kowalewski <jkowalewski@cthings.co>
kowalewskijan
force-pushed
the
sam0-i2c-timeouts-and-recovery
branch
from
515dc4d
to
293f076
Compare
There was a problem hiding this comment.
Hi @kowalewskijan ,
Interesting, a few points:
1- Could you explain on the commit messages what you are solving and why? It will be nice that you add information about a few use cases too. In this case, are you trying to solve some of the problems related on 36.6.2.4.2 Transmitting Address Packets?
2- I can imagine that it is not possible to have a HW test to avoid regressions for this, right?
3- Zephyr is moving to have all dependencies defined by each driver. This means that you need to add GPIO and PINCTRL dependencies at Kconfig.
| pinctrl_configure_pins(&soc_pin_sda, 1, PINCTRL_REG_NONE); | ||
| pinctrl_configure_pins(&soc_pin_scl, 1, PINCTRL_REG_NONE); | ||
|
|
There was a problem hiding this comment.
Why do you need this? Why not use below?
retval = pinctrl_apply_state(cfg->pcfg, PINCTRL_STATE_DEFAULT);
if (retval < 0) {
return retval;
}
| const struct device *sda_dev = sam_port_devs[sda_port_idx]; | ||
| const struct device *scl_dev = sam_port_devs[scl_port_idx]; |
There was a problem hiding this comment.
Could you pointing out an example where you found different ports for I2C pins at same?
Adds configurable timeout for I2C transactions and provides bus recovery functionality.
Tested on SAME53J20A