shell: backend: telnet: Don't assert if connection closed #78976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping @carlescufi @jakub-uC |
jakub-uC
approved these changes
Oct 9, 2024
jukkar
approved these changes
Oct 9, 2024
The code in shell_ops.c that calls telnet_write will assert if it returns non-zero. For a telnet shell it's normal that the network might disconnect unexepectedly, so that should not trigger an assert. Fixes zephyrproject-rtos#67637 Link: zephyrproject-rtos#67637 Signed-off-by: Kevin ORourke <kevin.orourke@ferroamp.se>
kevinior
force-pushed
the
fix_telnet_shell_asserts
branch
from
dc1d48a to
4f7ae6e
Compare
Contributor
Author
|
Rebased on current main since it looks like there was some i3c-related CI breakage when I originally created this PR. |
jukkar
approved these changes
Oct 10, 2024
Contributor
Contributor
|
I do not see a reason why we shouldn't, but I am not a telnet expert. @rlubos do you have any opinion? |
Contributor
|
This is a valid bugfix so I don't see why not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in shell_ops.c that calls telnet_write will assert if it returns non-zero. For a telnet shell it's normal that the network might disconnect unexpectedly, so that should not trigger an assert.
Fixes #67637
Link: #67637