Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: wifi: nrfwifi: Enable variable network configurations #78852

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

D-Triveni
Copy link

Add a name to the existing Kconfig choice for better clarity. Add variable network configuration control into the driver, removing the need for per-sample settings.

sachinthegreen
sachinthegreen previously approved these changes Sep 25, 2024
jukkar
jukkar previously approved these changes Sep 26, 2024
@rlubos
Copy link
Contributor

rlubos commented Sep 26, 2024

It seems that nucleo_h723zg + shield configuration was already on the edge when it comes to RAM (99.53% on main), with the massive net buf space it now overflows. Not sure if it's better to keep the defaults smaller, or choose different platform for testing.

sachinthegreen
sachinthegreen previously approved these changes Oct 8, 2024
sachinthegreen
sachinthegreen previously approved these changes Oct 17, 2024
jukkar
jukkar previously approved these changes Oct 17, 2024
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 21, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
Update kconfig choice name to enable overriding
from other parts of the code.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…urations

Add variable network configuration control into the driver,
removing the need for per-sample settings.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718 pushed a commit to krish2718/sdk-zephyr that referenced this pull request Oct 22, 2024
…leo_h723zg target

Enable fixed data buffers for nucleo_h723zg target to prevent RAM overflows
with variable network buffers usage.

Upstream PR: zephyrproject-rtos/zephyr#78852

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants