net: dns: Add per socket user data for the dispatcher #78148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket services API has a limitation where the user data is shared between file descriptors described in the same service. This can cause problem in DNS dispatcher where each listened socket needs to have their own dispatcher struct set as user data so that we can map between dispatcher context and socket. Solve this by always have a dispatcher table as user data, and then have the actual mapping done via the dispatcher table when receiving data to the dispatcher socket. Fixes zephyrproject-rtos#78146 Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
If the dispatcher is muxing the connection i.e., so there are two services for the same port, then mark service socket descriptor of the service with the socket number so that "net sockets" shell command can show a proper value for it. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no>
rlubos
approved these changes
Sep 9, 2024
pdgendt
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket services API has a limitation where the user data is shared between file descriptors described in the same service.
This can cause problem in DNS dispatcher where each listened socket needs to have their own dispatcher struct set as user data so that we can map between dispatcher context and socket. Solve this by always have a dispatcher table as user data, and then have the actual mapping done via the dispatcher table when receiving data to the dispatcher socket.
Fixes #78146