soc: dts: drivers: add SoCs for amebadplus series #78036

zjian-zhang · 2024-09-05T07:49:54Z

The amebadplus microcontroller (MCU) is an advanced system-on-chip (SoC) featuring an Arm® Cortex®-M55 and Cortex®-M23, large Flash and SRAM memories, and supports dual-band Wi-Fi 4(2.4GHz + 5GHz) and BLE5.0 specifications.

The initial support for the board includes GPIO, PINCTRL and Loguart(serial).

github-actions · 2024-09-05T07:50:29Z

Hello @zjian-zhang, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

zephyrbot · 2024-09-05T07:50:52Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_realtek 🆕	N/A (Added)	zjian-zhang/hal_realtek@`fc06336` (`main`)	N/A

⛔ DNM label due to: 1 added project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm

Please read and follow the contribution guidelines https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribute-guidelines we do not shove everything into a single commit for multiple areas, they must be distinct

boards/realtek/rtl872xda_evb/rtl872xda_evb_defconfig

soc/realtek/ameba/amebadplus/Kconfig.soc

soc/realtek/ameba/amebadplus/Kconfig

west.yml

drivers/usb/udc/udc_ameba.c

zjian-zhang · 2024-12-09T05:54:08Z

Please help to check again if there are any problems. thanks.

PR reduced to MVP as requested.

nordicjm · 2024-12-20T11:36:52Z

dts/arm/realtek/amebadplus/amebadplus.dtsi

+			reg = <0x4100f000 0x100>;
+			interrupts = <27 0>;
+			current-speed = <1500000>;
+			status = "okay";


nordicjm · 2024-12-20T11:37:51Z

dts/arm/realtek/amebadplus/amebadplus.dtsi

+				compatible = "soc-nv-flash";
+				erase-block-size = <DT_SIZE_K(4)>;
+				write-block-size = <4>;
+				/* Flash size is specified in board dts */


how can a board set the size of flash on a soc?

in 'boards/realtek/rtl872xda_evb/rtl872xda_evb.dts' we use

/* 4MB flash */ &flash0 { reg = <0x0e000020 DT_SIZE_M(4)>; };

But how? The flash is part of the SoC itself, how can it be defined at a board level?

The flash is part of the board, not the SoC.

nordicjm · 2024-12-20T11:39:17Z

soc/realtek/ameba/amebadplus/soc.c

+	return 0;
+}
+
+SYS_INIT(amebadplus_init, PRE_KERNEL_1, 0);


use soc hooks

nordicjm · 2024-12-20T11:39:58Z

soc/realtek/ameba/common/os_wrapper/CMakeLists.txt

+
+zephyr_include_directories(include)
+
+# add_subdirectory(source)


nordicjm · 2024-12-20T11:40:26Z

soc/realtek/ameba/common/os_wrapper/include/os_wrapper_memory.h

+ * @brief  Allocate memory from the heap. For FreeRTOS, map to pvPortMalloc
+ *         The buffer value is random


why are there comments about freertos?

already removed

nordicjm · 2024-12-20T11:41:21Z

soc/realtek/ameba/common/os_wrapper/include/os_wrapper_mutex.h

+ * handle.
+ * @retval
+ */
+int rtos_mutex_create(rtos_mutex_t *pp_handle);


@gmarull can you make heads or tails of this?

Our driver requires semaphore services provided by the OS. By using this interface, our driver can support different operating systems.

Why are the drivers not in zephyr in the drivers folder like every other vendor?

Apologies for the misunderstanding. The code in the HAL repositories requires these APIs, and the review comment in the HAL module request stating ‘Zephyr glue code is NOT allowed in HAL repositories’ necessitates moving these APIs to the Zephyr repository.

nordicjm · 2024-12-20T11:43:08Z

boards/realtek/rtl872xda_evb/doc/index.rst

+Supported Features
+==================
+
+Current Zephyr's board target ``rtl872xda_evb`` supports the following features:


Suggested change

Current Zephyr's board target ``rtl872xda_evb`` supports the following features:

Currently Zephyr's ``rtl872xda_evb`` board supports the following features:

nordicjm · 2024-12-20T11:43:39Z

boards/realtek/rtl872xda_evb/doc/index.rst

+
+See the ApplicationNote chapter Image Tool from documentation links for more details.
+
+#. Environment Requirements: EX. WinXP, Win 7 or later, Microsoft .NET Framework 4.0.


so this device is completely unusable on linux or mac? west flash also cannot work?

We currently do not support the ‘west flash’ command. In the future, we will provide a Python script to enable downloading across all platforms by loguart.

nordicjm · 2024-12-20T11:44:39Z

west.yml

@@ -212,6 +214,12 @@ manifest:
      path: modules/hal/quicklogic
      groups:
        - hal
+    - name: hal_realtek


module commit needs to be before everything else, can't add code that uses a module before the module is present

We submitted a HAL module request for hal_realtek, but it was not approved yet.

it still needs to be the first commit here, you can amend the commit later when the HAL is approved and merged

Thank you, I have adjusted the submission order, but the HAL has not been approved by the TSC yet. Could you help prioritize the review with the TSC?

nordicjm · 2025-02-13T13:05:25Z

dts/arm/realtek/amebadplus/amebadplus.dtsi

+		spic: flash-controller@40128000 {
+			compatible = "realtek,ameba-flash-controller";
+			reg = <0x40128000 0x200>;
+			/* interrupts = <51 0>; */


line to go?

nordicjm · 2025-02-13T13:08:12Z

west.yml

@@ -212,6 +214,12 @@ manifest:
      path: modules/hal/quicklogic
      groups:
        - hal
+    - name: hal_realtek


it still needs to be the first commit here, you can amend the commit later when the HAL is approved and merged

zjian-zhang · 2025-03-11T09:38:01Z

Please help to check the issue. thanks a lot.

Realtek HAL (Hardware Abstraction Layer) provides a low level peripheral configuration function. Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

add initial version of devicetree for amebadplus SOC. amebadplus devicetree file is main platform dtsi file, which should be included from board dts (e.g rtl872xda_evb.dts) Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

Add initial version of Amebadplus Soc integration Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

add amebadplus pin controller driver Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

loguart driver for amebadplus Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

GPIO driver for amebadplus Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

add initial version of rtl872xda_evb board Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

This commit adds maintainers for hal_realtek repository Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

sonarqubecloud · 2025-05-17T08:46:59Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zjian-zhang requested a review from mbolivar-ampere as a code owner September 5, 2024 07:49

zephyrbot added the manifest label Sep 5, 2024

zephyrbot requested review from anangl, dcpleung, decsny, gmarull, henrikbrixandersen, jfischer-no, jukkar, Kludentwo, krish2718, nordic-krch, rlubos, tbursztyka, teburd and tmon-nordic September 5, 2024 07:50

zephyrbot added manifest-hal_realtek_ameba manifest-hal_realtek labels Sep 5, 2024

zephyrbot assigned teburd Sep 5, 2024

zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Sep 5, 2024

nordicjm requested changes Sep 5, 2024

View reviewed changes

nordicjm reviewed Sep 5, 2024

View reviewed changes

west.yml Outdated Show resolved Hide resolved

jfischer-no requested changes Sep 5, 2024

View reviewed changes

drivers/usb/udc/udc_ameba.c Outdated Show resolved Hide resolved

decsny removed their request for review September 5, 2024 14:54

zjian-zhang mentioned this pull request Sep 6, 2024

HAL module request: hal_realtek #78084

Open

jukkar removed their request for review September 10, 2024 08:29

zjian-zhang force-pushed the main branch from 62cebd2 to c355951 Compare September 11, 2024 13:18

zephyrbot requested a review from de-nordic September 11, 2024 13:19

zjian-zhang force-pushed the main branch from 333cc9b to 6b51488 Compare November 22, 2024 05:57

zjian-zhang requested a review from stephanosio December 16, 2024 05:41

nordicjm reviewed Dec 20, 2024

View reviewed changes

zjian-zhang force-pushed the main branch 2 times, most recently from 3dffaab to 8a6eadc Compare December 24, 2024 08:39

fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025

zjian-zhang force-pushed the main branch from 8a6eadc to c18f3a0 Compare February 11, 2025 01:44

zephyrbot added the platform: Realtek EC label Feb 11, 2025

zjian-zhang requested review from nordicjm and rruuaanng February 13, 2025 13:02

nordicjm reviewed Feb 13, 2025

View reviewed changes

zjian-zhang force-pushed the main branch 2 times, most recently from 26bcfe3 to 9a62417 Compare February 17, 2025 12:35

Kludentwo removed their request for review March 3, 2025 19:56

keith-zephyr removed the platform: Realtek EC label Apr 14, 2025

zjian-zhang added 8 commits May 17, 2025 16:14

west.yml: Add Realtek HAL as a new HAL module

58a097e

Realtek HAL (Hardware Abstraction Layer) provides a low level peripheral configuration function. Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

dts: arm: introduce amebadplus SOC Devicetree

b1a7de2

add initial version of devicetree for amebadplus SOC. amebadplus devicetree file is main platform dtsi file, which should be included from board dts (e.g rtl872xda_evb.dts) Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

soc: add realtek amebadplus SOC integration

a9c648c

Add initial version of Amebadplus Soc integration Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

drivers: pinctrl: add amebadplus pin controller driver

38f66e4

add amebadplus pin controller driver Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

drivers: serial: add amebadplus loguart driver

296fb5b

loguart driver for amebadplus Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

drivers: gpio: add amebadplus gpio driver

38c6962

GPIO driver for amebadplus Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

boards: add rtl872xda_evb board

0a59757

add initial version of rtl872xda_evb board Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

MAINTAINERS: Add hal_realtek as a new HAL module

9878f1b

This commit adds maintainers for hal_realtek repository Signed-off-by: zjian zhang <zjian_zhang@realsil.com.cn>

zjian-zhang force-pushed the main branch from 9a62417 to 9878f1b Compare May 17, 2025 08:18

github-actions bot added the platform: Realtek EC label May 17, 2025


		zephyr_include_directories(include)

		# add_subdirectory(source)

		* @brief Allocate memory from the heap. For FreeRTOS, map to pvPortMalloc
		* The buffer value is random

	Current Zephyr's board target ``rtl872xda_evb`` supports the following features:
	Currently Zephyr's ``rtl872xda_evb`` board supports the following features:


		See the ApplicationNote chapter Image Tool from documentation links for more details.

		#. Environment Requirements: EX. WinXP, Win 7 or later, Microsoft .NET Framework 4.0.

soc: dts: drivers: add SoCs for amebadplus series #78036

Are you sure you want to change the base?

soc: dts: drivers: add SoCs for amebadplus series #78036

Conversation

zjian-zhang commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 5, 2024

Uh oh!

zephyrbot commented Sep 5, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nordicjm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zjian-zhang commented Dec 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zjian-zhang Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zjian-zhang commented Mar 11, 2025

Uh oh!

sonarqubecloud bot commented May 17, 2025

Quality Gate passed

Uh oh!

Uh oh!

zjian-zhang commented Sep 5, 2024 •

edited

Loading

zephyrbot commented Sep 5, 2024 •

edited by github-actions bot

Loading

zjian-zhang Dec 24, 2024 •

edited

Loading