video: gc2145: add Galaxy Core GC2145 sensor support and basic controls

[uLipe]

Adding Galaxy Core, GC2145 Image sensor I2C driver, the datasheet documentation is very unclear, and the only two references I found is the linux kernel driver and the driver used in Arducam.

This sensor is the same used in the cameras used by Arduino Nicla Vision, so having this sensor support aims to unblock the full support of the camera for the Nicla Vision board (STM32 DCMI is already present in the main branch).

Unfortunately those two drivers uses lots of hardcoded registers to getting the camera full working, so only some very basic controls and the RGB565 format is supported.

The Arduino Nicla Vision support has been merged recently to the upstream and the camera is one of the outstanding feature that needs to be supported:

#77501

[uLipe]

Not sure if the compatible should be TI or GC from galaxy core, it seems the company now belongs to TI, happy to hear your suggestions.

[kartben]

Adding Galaxy Core, now TI

Are you sure? 🤔 My guess is Google's first hit for this IC is what got you confused but I really can't seem to find any mention of the company having been acquired?
It also seems to still operate as an independent publicly traded company.

[uLipe]

Adding Galaxy Core, now TI

Are you sure? 🤔 My guess is Google's first hit for this IC is what got you confused but I really can't seem to find any mention of the company having been acquired? It also seems to still operate as an independent publicly traded company.

@kartben you are right, I was tricked because the only PDF datasheet I found opened on the Texas Instruments domain, but it is actually in the TI e2e forum, in any case I changed to reflect the Galaxy Core initials the bindings and the compat symbol.

[uLipe]

Thanks @fabiobaltieri , I mostly copied this driver from the OV2640, which seems to be the most complete one.

I Will apply the suggestions soon.

[fabiobaltieri]

Thanks @fabiobaltieri , I mostly copied this driver from the OV2640, which seems to be the most complete one.

I see, the subsystem is "odd fixes" unfortunately so the code is somewhat incoherent, if you have spare cycles for it there's definitely space for improvements, like adding a common subsys/logging/Kconfig.template.log_config and clean up the log setup for video drivers.

[uLipe]

@fabiobaltieri I pick some spare time, to see what I can improve regarding the log and error handling on the video sensor drivers

[uLipe]

Hi folks, any updates here?

Thank you :)

[uLipe]

@fabiobaltieri could you have another look?

Also @pillo79 , @loicpoulain can I have your input as well, I already have a temporary branch with complete camera support PoC for the Nicla vision, only depending on merging this sensor driver.

Thank you in advance for your efforts.

[pillo79]

Thanks for your efforts on the Nicla @uLipe! 🥳
I am no expert in this subsystem, but it looks proper to me on the implementation side. I can offer additional nagging on the style though... 🙂

The list below is not complete, there are several similar lines. Please review the whole file and fix the indentations so that:

• all wrapping lines align to the rightmost open brace
• use tabs (set size 8 on your editor) and then spaces for precise aligment
• consider wrapping anything after 80 chars, absolute limit is 100 chars per line including indent.

These are a quite strict convention in Zephyr.

[uLipe]

Thanks @pillo79 for your review , it is odd why the compliance check (neither local, nor the remote) are not failling with those style stuff, in general they should check for this and fail in CI

[uLipe]

@pillo79 , I just ran the clang-format and did some small adjustements, also ran the check compliance script locally before push.

I'm not sure why those spacing and alignment stuff was not captured, in any case PTAL again when you find time.

[uLipe]

@fabiobaltieri , just letting the device tree to set the speed is sufficient and it is not needed to be called again.

I Also tried to document better the magics based on the datasheet I found of the GC2145, PTAL again when you can.

[loicpoulain]

LGTM

[uLipe]

@fabiobaltieri , @pillo79 , sorry folks to bother you on that again, it is just because I need your okay to proceed on this one and then unblock nicla vision camera full support.

[josuah]

Here is an unofficial review (I'm not assigned to Video yet).

High time that I implement video_sensor_skeleton.c to have something
review-ready to use as a starting point!

• drivers: video: sensors: add a sensor_skeleton.c to speed-up contribution of simple sensors #73867

Thank you for this extra sensor, first of Galaxy Core family!

[uLipe]

Thanks for reviewing it, PTAL again @josuah , @loicpoulain

[josuah]

Pointing at it in case you wanted to convert all occurrences of k_msleep() to k_sleep(K_MSEC())...

Maybe this is where the comment block belongs the most, as it is the longest delay?

[josuah]

Note: my reviews are indicative only (gray mark, not green), but glad if that helps saving some time for when the actual reviews come.

[josuah]

Pointing at it in case you wanted to convert all occurrences of k_msleep() to k_sleep(K_MSEC())...

[josuah]

Pointing at it in case you wanted to convert all occurrences of k_msleep() to k_sleep(K_MSEC())...

[pillo79]

Thanks for the review @josuah. Will gladly lend my +1!

[kartben]

Here is an unofficial review (I'm not assigned to Video yet).

@josuah feel very free to send a PR against MAINTAINERS.yml to add yourself as a collaborator :)