drivers: sdhc: imx_usdhc: assume card is present if no detection method #77301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The imx USDHC driver previously queried the peripheral's internal card detect signal to check card presence if no card detect method was configured. However, some boards do not route the card detect signal and do not work correctly with the DAT3 detection method supported by this peripheral. As a fallback, assume the card is present in the slot but log a warning to the user. Fixes zephyrproject-rtos#42227 Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
NXP IMX USDHC fallback card detection method changed from querying the peripheral to simply assuming the card was present. Add a note to the migration guide highlighting this and explaining how to restore the previous behavior for anyone using this detection method. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>
danieldegrasse
requested review from
dleach02 and
mmahadevan108
as code owners
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
MarkWangChinese,
dbaluta,
decsny,
dkalowsk,
kartben and
manuargue
decsny
approved these changes
Aug 20, 2024
dleach02
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imx USDHC driver previously queried the peripheral's internal card
detect signal to check card presence if no card detect method was
configured. However, some boards do not route the card detect signal and
do not work correctly with the DAT3 detection method supported by this
peripheral. As a fallback, assume the card is present in the slot but
log a warning to the user.
Fixes #42227