code_relocation: Add option to specify load memory segment #76513
+64
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no way to select a load memory segment other than ROMABLE_REGION. This introduces an optional argument to zephyr_code_relocate() Signed-off-by: Dennis Grijalva <dennisgrijalva@meta.com>
Provide an example of loading code from a region other than ROMABLE_REGION Signed-off-by: Dennis Grijalva <dennisgrijalva@meta.com>
dennisgr102
changed the title
zephyrbot
added
area: Samples
zephyrbot
requested review from
57300,
ceolin,
dcpleung,
jeremybettis,
kartben,
nashif,
nordicjm and
tejlmand
tejlmand
requested changes
Oct 3, 2024
| # <mem_region>[\ :program_header]:<flag_1>[;<flag_2>...]:<file_1>[;<file_2>...] | ||
| # Returns a 4-tuple with them: (mem_region, program_header, flags, files) | ||
| # <mem_region>[:PHDR=program_header][:LMEM=load_memory]:FLAGS=<flag_1>[;<flag_2>...]:FILES=<file_1>[;<file_2>...] | ||
| # Returns a 5-tuple with them: (mem_region, program_header, load_mem, flags, files) | ||
| # If no `program_header` is defined, returns an empty string |
There was a problem hiding this comment.
I guess a line similar If no program_header is needed for `load_memory.
Comment on lines
+514
to
+515
| line_split = line.split(':') | ||
| arg_dict = {i.split('=')[0]: i.split('=')[1] for i in line_split[1:]} |
There was a problem hiding this comment.
afaict this breaks on Windows where paths contains :, such as c:/.
Please also take a look at this comment: #74402 (comment)
Perhaps you didn't notice the comment you removed here:
zephyr/scripts/build/gen_relocate_app.py
Line 508 in c710f88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to select a load memory segment other than ROMABLE_REGION. This introduces an optional argument (LMEM) to zephyr_code_relocate(). An example usecase is provided.