drivers: dac: dacx3608: add broadcast register for synchronized output #74633
Conversation
|
Hello @bbooher, and thank you very much for your first pull request to the Zephyr project! |
|
Partial implementation for: #73090 |
bbooher
changed the title
bbooher
force-pushed
the
dacx3608-broadcast
branch
from
bcf4a1d
to
cdfd8f8
Compare
bbooher
changed the title
bbooher
force-pushed
the
dacx3608-broadcast
branch
from
cdfd8f8
to
52434ce
Compare
|
@bbooher Please have a look at the failed compliance check. |
…tput The dacx3608 line supports a broadcast register so all configured channels can output a singular value, simultaneously. This drastically reduces I2C overhead when using multi-channel control. An API addition was necessary to support a global broadcast channel number. The API addition does not break the write_value() implementation for other DAC drivers in the repo. This change is based on an out-of-tree driver developed internally to handle this use case. Alternative to the API change, could be a KConfig option or device tree entry. Also, no support for the Broadcast channel was added to the channel_setup() implementation - this may or may not be confusing. I believe it makes sense to maintain explicit setup calls for each channel intended to be configured. Signed-off-by: Ben Booher <benbooher@pull-repo.com>
bbooher
force-pushed
the
dacx3608-broadcast
branch
from
52434ce
to
bc54cb7
Compare
I believe it was a mismatch in git username and signed-off-by name. I used the --signoff parameter this time and re-pushed. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
There was a problem hiding this comment.
I agree this feature can be added independent of the discussion in #73090 for synchronizing the outputs using the latch pin.
|
@KwonTae-young Added you as a reviewer as you have contributed another TI DAC driver in the past. |
|
@martinjaeger @KwonTae-young - Bumping this PR. |
The dacx3608 line supports a broadcast register so all configured channels can output a singular value, simultaneously. This drastically reduces I2C overhead when using multi-channel control. An API addition was necessary to support a global broadcast channel number. The API addition does not break the write_value() implementation for other DAC drivers in the repo. This change is based on an out-of-tree driver developed internally to handle this use case.
Alternative to the API change, could be a KConfig option or device tree entry. Also, no support for the Broadcast channel was added to the channel_setup() implementation - this may or may not be confusing. I believe it makes sense to maintain explicit setup calls for each channel intended to be configured.