boards: norik: Add support for Norik Octopus SoM & IO-Board #74523

FPlohl · 2024-06-19T07:29:38Z

Add support for Norik Octopus SoM & IO-Board. Octopus SoM is based on nRF9160, IO-board is "expander" PCB for the SoM.

Implemented fixes mentioned in boards: norik: Add support for Norik Octopus SoM & IO-Board #74239. That pull request was accidentally closed.

nordicjm · 2024-07-08T08:59:15Z

boards/norik/octopus_io_board/doc/index.rst

+Building an application
+=======================
+
+In most case you'll need to use ``octopus_io_board_ns`` target for building examples.


name is not correct

Fixed in recent changes

nordicjm · 2024-07-08T08:59:19Z

boards/norik/octopus_io_board/doc/index.rst

+=======================
+
+In most case you'll need to use ``octopus_io_board_ns`` target for building examples.
+Some examples don't require non secure mode and can be built without ``octopus_io_board_ns`` target.


Fixed in recent changes

boards/norik/octopus_io_board/doc/index.rst

nordicjm · 2024-07-08T09:00:12Z

boards/norik/octopus_io_board/octopus_io_board_common.dtsi

+	peripheral-power-controller {
+		compatible = "gpio-keys";
+
+		pwrgpio0: pwrgpio_0 {
+			label = "VP on/off";
+			gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>;
+		};
+
+		pwrgpio1: pwrgpio_1 {
+			label = "CHG control";
+			gpios = <&gpio0 20 (GPIO_ACTIVE_LOW)>;
+		};
+
+	};


these are not buttons, a custom dts is needed

Fixed in recent changes

nordicjm · 2024-07-08T09:02:26Z

boards/norik/octopus_io_board/octopus_io_board_common.dtsi

+		watchdog0 = &wdt0;
+		ldoctrl = &pwrgpio0;
+		chgctrl = &pwrgpio1;
+		bq25180 = &bq25180;


bq25180 is not used in samples, neither are ldoctrl or chgctrl

Fixed in recent changes

nordicjm · 2024-07-08T09:02:48Z

boards/norik/octopus_io_board/octopus_io_board_common.dtsi

+	pinctrl-names = "default", "sleep";
+
+	bq25180: bq25180@6a {
+		compatible = "i2c-device";


seems like a driver is missing?

Fixed in recent changes

nordicjm · 2024-07-08T09:02:59Z

boards/norik/octopus_io_board/octopus_io_board_common.dtsi

+	bq25180: bq25180@6a {
+		compatible = "i2c-device";
+		status = "okay";
+		label = "BQ25180";


we do not use labels in peripherals

Fixed in recent changes

nordicjm · 2024-07-08T09:03:38Z

boards/norik/octopus_som/doc/index.rst

+In most case you'll need to use ``octopus_som_ns`` target for building examples.
+Some examples don't require non secure mode and can be built without ``octopus_som_ns`` target.


Fixed in recent changes

nordicjm · 2024-07-08T09:03:58Z

boards/norik/octopus_som/octopus_som_common.dtsi

+		led0 = &led0;
+		pwm-led0 = &pwm_led0;
+		watchdog0 = &wdt0;
+		simselect = &sim_select;


Fixed in recent changes

nordicjm · 2024-08-21T09:21:55Z

@FPlohl tests are failing, can you fix?

nordicjm · 2024-09-02T08:10:08Z

boards/norik/octopus_som/Kconfig

+	int "Init priority"
+	default 99
+	help
+		Init priority for board control.


1x tab followed by 2x spaces for help text indent

nordicjm · 2024-09-02T08:12:20Z

boards/norik/octopus_som/board.c

+	}
+
+	return ret;
+	}


nordicjm · 2024-09-02T08:12:43Z

boards/norik/octopus_som/board.c

+static int octopus_som_sim_select(void)
+{
+	const struct gpio_dt_spec simctrl = GPIO_DT_SPEC_GET(DT_PATH(sim_select), sim_gpios);
+
+	if (!gpio_is_ready_dt(&simctrl)) {
+		LOG_ERR("SIM select GPIO not available");
+		return -ENODEV;
+	}
+
+	if (DT_ENUM_IDX(SIM_SELECT_NODE, sim) == 0) {
+		(void)gpio_pin_configure_dt(&simctrl, GPIO_OUTPUT_LOW);
+		LOG_INF("On-board SIM selected");
+	} else {
+		(void)gpio_pin_configure_dt(&simctrl, GPIO_OUTPUT_HIGH);
+		LOG_INF("External SIM selected");
+	}
+	return 0;
+}
+
+
+static int octopus_som_init(void)


not sure why these need to be 2 different functions

nordicjm · 2024-09-02T08:12:57Z

boards/norik/octopus_som/board.c

+
+	ret = octopus_som_sim_select();
+	if (ret < 0) {
+		LOG_ERR("Failed to select SIM, error %d", ret);


when this is just showing the same error as the other function

nordicjm · 2024-09-02T08:14:11Z

boards/norik/octopus_som/doc/index.rst

+=======================
+
+In most case you'll need to use ``octopus_som/nrf9160/ns`` target for building examples.
+Some examples don't require non secure mode and can be built with ``octopus_som`` target.


*octopus_som/nrf9160

nordicjm · 2024-09-02T08:14:17Z

boards/norik/octopus_som/doc/index.rst

+
+.. zephyr-app-commands::
+   :zephyr-app: samples/basic/blinky
+   :board: octopus_som


*octopus_som/nrf9160

nordicjm · 2024-09-02T08:15:15Z

boards/norik/octopus_io_board/Kconfig

+	int "Init priority"
+	default 99
+	help
+		Init priority for board control.


apply comments from other commit to this commit

nordicjm

Apply comments to both commits

nordicjm · 2024-09-11T09:34:33Z

boards/norik/octopus_som/doc/index.rst

+Building an application
+=======================
+
+In most case you'll need to use ``octopus_som/nrf9160/ns`` target for building examples.


board target

nordicjm · 2024-09-11T09:35:45Z

boards/norik/octopus_som/octopus_som_common.dtsi

+	};
+};
+
+&flash0 {


this is now all gone, see #76452

I'm not sure I understand what needs to be done here. Edit: nevermind, looked into recent commits

boards/norik/octopus_io_board/doc/index.rst

FPlohl · 2024-10-01T08:15:46Z

@nordicjm twister tests seem to be canceled. Can you re-run them or give some insight why they failed?

nordicjm · 2024-10-01T08:22:24Z

Compliance failure

nordicjm

Minor nits. then good

nordicjm · 2024-10-11T07:30:50Z

boards/norik/octopus_som/octopus_som_common-pinctrl.dtsi

+			low-power-enable;
+		};
+	};
+


Suggested change

nordicjm · 2024-10-11T07:31:22Z

boards/norik/octopus_som/Kconfig

+
+config OCTOPUS_SOM_CONTROL_INIT_PRIORITY
+	int "Init priority"
+	default 99


select PINCTRL

Because you have a .c file which is using it. Breaks how? If it is a Kconfig error then add a new hidden Kconfig that selects that symbol

I've added config BOARD_OCTOPUS_SOM that contains select PINCTRL. Now it works as expected.

nordicjm · 2024-10-11T07:32:17Z

boards/norik/octopus_som/doc/index.rst

+Hardware
+********
+
+The Norik Octopus SoM supports the following hardware features:


Suggested change

The Norik Octopus SoM supports the following hardware features:

The ``octopus_som/nrf9160`` and ``octopus_som/nrf9160/ns`` board targets support the following hardware features:

nordicjm · 2024-10-11T07:33:09Z

boards/norik/octopus_io_board/octopus_io_board_common-pinctrl.dtsi

+			low-power-enable;
+		};
+	};
+


Suggested change

nordicjm · 2024-10-11T07:33:36Z

boards/norik/octopus_io_board/Kconfig

+
+config OCTOPUS_IO_BOARD_CONTROL_INIT_PRIORITY
+	int "Init priority"
+	default 99


as per other comment

gmarull · 2024-10-14T09:38:17Z

boards/norik/octopus_io_board/board.c

+	const struct device *charger = DEVICE_DT_GET(CHARGER_NODE);
+
+	if (!device_is_ready(charger)) {
+		LOG_ERR("Charger not ready");
+		return -ENODEV;
+	}
+
+	const struct charger_config *cfg = charger->config;
+
+	ret = i2c_reg_update_byte_dt(&cfg->i2c, 0x5, 0xff, 0b00100100);
+
+	if (ret < 0) {
+		LOG_ERR("Failed to set charger CHARGECTRL0 register");
+		return ret;
+	}
+	LOG_INF("Set CHARGECTRL0 register");
+
+	return 0;


-1, what is this?

Set input voltage treshold for on-board bq25180 charger. If not set, solar MPPT IC can't supply power efficiently.

this needs to be handled by the driver. device's config is not meant for public access.

I understand, we can remove it. But I just want to point out that some other boards like Actinius boards use it to set some peripherals.

~~Some code gets in without proper reviews from time to time.~~ that code is not accessing any driver internals nor changing a device state (eg i2c transfers) outside of its context.

gmarull · 2024-10-21T15:47:43Z

boards/norik/octopus_io_board/board.c

+	return 0;
+}
+
+SYS_INIT(octopus_io_board_init, POST_KERNEL, CONFIG_OCTOPUS_IO_BOARD_CONTROL_INIT_PRIORITY);


use board hooks?

gmarull · 2024-10-21T15:49:44Z

boards/norik/octopus_io_board/dts/bindings/norik,power-controller.yaml

+description: |
+  This binding is used for controlling battery charger and
+  LDO regulator on the Octopus IO Board.
+
+compatible: "norik,power-controller"


what is this?

Description, but since we did not supply a driver we'll be removing this for now.

gmarull · 2024-10-21T15:50:15Z

boards/norik/octopus_io_board/dts/bindings/norik,power-controller.yaml

+    zephyr,code:
+      type: int
+      description: Key code to emit.


why is input subsys stuff showing up here?

Removed as above.

gmarull · 2024-10-21T15:50:51Z

boards/norik/octopus_io_board/octopus_io_board_common.dtsi

+	peripheral-power-controller {
+		compatible = "norik,power-controller";
+
+		pwrgpio0: pwrgpio_0 {
+			label = "VP on/off";
+			gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>;
+		};
+
+		pwrgpio1: pwrgpio_1 {
+			label = "CHG control";
+			gpios = <&gpio0 20 (GPIO_ACTIVE_LOW)>;
+		};
+
+	};


looks like these are on/off switches? why not regulator-gpio?

gmarull · 2024-10-21T15:51:08Z

boards/norik/octopus_io_board/octopus_io_board_defconfig

+
+# Enable GPIO
+CONFIG_GPIO=y
+CONFIG_INPUT_GPIO_KEYS=n


Accidentally left in code, removed

gmarull · 2024-10-21T15:51:24Z

boards/norik/octopus_io_board/octopus_io_board_defconfig

+CONFIG_UART_CONSOLE=y
+
+# Enable charger
+CONFIG_CHARGER=y


is this required to eg boot hello world?

No, removed

Add support for Norik Systems Octopus SoM based on nRF9160 SiP. Supported features: - LTE-M/NB-IoT - GPS - LED - 3-axis accelerometer Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>

Add support for Norik Systems Octopus IO-Board based on Norik Systems Octopus SoM. Supported features: - LTE-M/NB-IoT - GPS - LED - 3-axis accelerometer - Battery charger - Solar charger - SPI NOR flash - Nano SIM connector Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>

FPlohl force-pushed the main branch from 84cfe7c to 3827e81 Compare June 26, 2024 08:33

nordicjm requested review from kartben, anangl and nordicjm July 1, 2024 06:10

FPlohl force-pushed the main branch 2 times, most recently from ef78b27 to 7376d17 Compare July 5, 2024 06:27

nordicjm reviewed Jul 8, 2024

View reviewed changes

nordicjm requested a review from gmarull July 8, 2024 09:04

FPlohl force-pushed the main branch from 7376d17 to 1de6c0a Compare July 22, 2024 09:22

FPlohl requested a review from nordicjm August 5, 2024 07:49

FPlohl force-pushed the main branch from 1de6c0a to a8601c0 Compare September 2, 2024 07:51

nordicjm reviewed Sep 2, 2024

View reviewed changes

FPlohl force-pushed the main branch from a8601c0 to fd6558b Compare September 2, 2024 13:12

nordicjm requested changes Sep 11, 2024

View reviewed changes

FPlohl force-pushed the main branch 2 times, most recently from fb5be5b to 2cb1c7a Compare September 23, 2024 10:55

FPlohl force-pushed the main branch 2 times, most recently from 5c43efb to defd842 Compare October 1, 2024 12:36

FPlohl requested a review from nordicjm October 3, 2024 06:22

nordicjm reviewed Oct 11, 2024

View reviewed changes

FPlohl force-pushed the main branch 2 times, most recently from 3cbce7a to b190fa0 Compare October 14, 2024 09:37

gmarull requested changes Oct 14, 2024

View reviewed changes

FPlohl force-pushed the main branch from b190fa0 to aa9e133 Compare October 21, 2024 06:41

FPlohl requested review from gmarull and nordicjm October 21, 2024 09:27

gmarull reviewed Oct 21, 2024

View reviewed changes

FPlohl added 2 commits October 23, 2024 11:08

boards: norik: Add support for Norik Octopus SoM

7b31264

Add support for Norik Systems Octopus SoM based on nRF9160 SiP. Supported features: - LTE-M/NB-IoT - GPS - LED - 3-axis accelerometer Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>

FPlohl force-pushed the main branch from aa9e133 to bbdd5c1 Compare October 23, 2024 09:10

zephyrbot added the area: Devicetree label Oct 23, 2024

zephyrbot requested review from decsny and galak October 23, 2024 09:11

FPlohl requested a review from gmarull October 23, 2024 11:00

		In most case you'll need to use ``octopus_som_ns`` target for building examples.
		Some examples don't require non secure mode and can be built without ``octopus_som_ns`` target.

	The Norik Octopus SoM supports the following hardware features:
	The ``octopus_som/nrf9160`` and ``octopus_som/nrf9160/ns`` board targets support the following hardware features:

boards: norik: Add support for Norik Octopus SoM & IO-Board #74523

Are you sure you want to change the base?

boards: norik: Add support for Norik Octopus SoM & IO-Board #74523

Conversation

FPlohl commented Jun 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm commented Aug 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FPlohl Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

FPlohl commented Oct 1, 2024

nordicjm commented Oct 1, 2024

nordicjm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FPlohl Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmarull Oct 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FPlohl Sep 12, 2024 •

edited

Loading

FPlohl Oct 14, 2024 •

edited

Loading

gmarull Oct 14, 2024 •

edited

Loading