-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: dac: Add support for Microchip MCP48XX devices #74340
base: main
Are you sure you want to change the base?
Conversation
Hello @emz229, and thank you very much for your first pull request to the Zephyr project! |
This driver covers the MCP4802, MCP4812, and MCP4822 DACs. Signed-off-by: Eric Schikschneit <eric.schikschneit@novatechautomation.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emz229 for your contribution.
Generally the PR looks good. However, I need to have some more thoughts regarding the latch pin for synchronization. Given that there are more chips with such a pin (e.g. TI dacx3608) we should find a generic solution for that and include the functionality into the actual DAC API.
Please note that we are currently still in feature freeze for Zephyr v3.7 and the PR can only be merged after that. I will come back with a suggestion regarding the latch pin ASAP.
@emz229 do you plan to come back to this PR? |
@MaureenHelm I am monitoring the thread where it is being discussed by several maintainers. See https://github.com/zephyrproject-rtos/zephyr/issues/73090 |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This driver covers the MCP4802, MCP4812, and MCP4822 DACs.