Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: dac: Add support for Microchip MCP48XX devices #74340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emz229
Copy link

@emz229 emz229 commented Jun 14, 2024

This driver covers the MCP4802, MCP4812, and MCP4822 DACs.

@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: DAC Digital-to-Analog Converter platform: Microchip MEC Microchip MEC Platform labels Jun 14, 2024
Copy link

Hello @emz229, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

This driver covers the MCP4802, MCP4812, and MCP4822 DACs.

Signed-off-by: Eric Schikschneit <eric.schikschneit@novatechautomation.com>
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emz229 for your contribution.

Generally the PR looks good. However, I need to have some more thoughts regarding the latch pin for synchronization. Given that there are more chips with such a pin (e.g. TI dacx3608) we should find a generic solution for that and include the functionality into the actual DAC API.

Please note that we are currently still in feature freeze for Zephyr v3.7 and the PR can only be merged after that. I will come back with a suggestion regarding the latch pin ASAP.

@MaureenHelm
Copy link
Member

@emz229 do you plan to come back to this PR?

@emz229
Copy link
Author

emz229 commented Aug 22, 2024

@MaureenHelm I am monitoring the thread where it is being discussed by several maintainers. See https://github.com/zephyrproject-rtos/zephyr/issues/73090

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DAC Digital-to-Analog Converter area: Devicetree Binding PR modifies or adds a Device Tree binding platform: Microchip MEC Microchip MEC Platform Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants