net: buf: Disallow blocking allocation in syswq #71697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
the
area: Networking Buffers
jori-nordic
force-pushed
the
buf-alloc-dont-wait-in-syswq
branch
from
94de455 to
a280b3a
Compare
|
@jori-nordic CI is failing due to a misspelled word. The change itself looks fine to me. |
jori-nordic
force-pushed
the
buf-alloc-dont-wait-in-syswq
branch
from
a280b3a to
b34f994
Compare
|
@jhedberg fixed, thanks |
jukkar
reviewed
Apr 22, 2024
| @@ -1315,14 +1315,19 @@ int net_buf_id(struct net_buf *buf); | |||
| /** | |||
There was a problem hiding this comment.
Minor nit, we usually have net: prefix instead of "networking" in commit subject that are related to networking files.
There was a problem hiding this comment.
got it, fixed 👍
There was a problem hiding this comment.
ah shoot looks like the CI re-runs when you only update the commit message. @stephanosio do you think we could make it so we only run the compliance in those cases?
jhedberg
approved these changes
Apr 22, 2024
Work items on the syswq should always run-to-completion. Override the timeout value to always be K_NO_WAIT. Allocating with K_FOREVER leads to deadlocks if the freeing also happens from the syswq. Non-zero timeouts are also not nice for the other users of the syswq. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
jori-nordic
force-pushed
the
buf-alloc-dont-wait-in-syswq
branch
from
b34f994 to
d4d5301
Compare
jori-nordic
changed the title
rlubos
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work items on the syswq should always run-to-completion.
Override the timeout value to always be K_NO_WAIT.
Allocating with K_FOREVER leads to deadlocks if the freeing also happens from the syswq. Non-zero timeouts are also not nice for the other users of the syswq.