OCPP 1.6 native stack #68739

ssekar15 · 2024-02-08T11:13:29Z

Add a support for Open Charge Point Protocol(OCPP v1.6) native stack

Basic support for open charge point protocol v1.6 as native stack with
below functionality

1. Framework for ocpp stack and central system communication using RPC over
   websocket according to occp-j.
2. Core profile with basic PDU

zephyrbot · 2024-02-08T11:14:19Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
json-c 🆕	N/A (Added)	linumiz/json-c@dev/zephyr	N/A

⛔ DNM label due to: 1 added project

Note: This message is automatically posted and updated by the Manifest GitHub Action.

jukkar

Some initial comments, will continue later.

include/zephyr/net/ocpp.h

lib/ocpp/Kconfig

lib/ocpp/include/ocpp_i.h

jukkar · 2024-02-08T15:24:21Z

lib/ocpp/src/core.c

+	fn = ctx->cfn[UnlockConnector];
+	fn(buf, sizeof(buf), resp, uid);


Using a fn variable seems pointless just for this one call, why not just do ctx->cfn[UnlockConnector](buf, ....);

made for better code readability

lib/ocpp/src/core.c

lib/ocpp/src/ocpp.c

jukkar · 2024-02-08T15:31:54Z

If this PR is still a draft (as indicated by the title), you can mark it as a draft in github. Search "Still in progress?" and there is a link at top right hand side of the page.

rlubos

Some initial thoughts. I think such a library should get a separate entry in CODEOWNERS/Maintainers file - IMO it's way too specialized to fall under general "networking" umbrella.

lib/CMakeLists.txt

lib/ocpp/Kconfig

lib/ocpp/include/ocpp_i.h

ssekar15 · 2024-02-12T12:37:26Z

depends on #66763

Describe OCPP Charge Point (CP) support and illustrate how to implement CP sample. Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

Add test suit for OCPP lib with one complete charging session with a random meter values. Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

A test sample for ocpp charge point with 2 connectors, central system steve server is used with test setup (public available) Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

add code owner for OCPP native stack Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

add json-c as external module and define CMake ane Kconfig compialtion control from zephyr tree. Commit also includes generated header files which are essential for compilation. config.h typically controls the available support in the toolchain and the current choice with zephyr is done using picolibc. Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>

This commit adds the new external json-c modules to the MAINTAINERS.yml file. Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>

my comments re: documentation have been addressed - thanks!

github-actions · 2024-07-27T00:30:03Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

jukkar · 2024-07-27T08:21:27Z

@ssekar15 are you planning to work on this PR?

ssekar15 · 2024-07-27T12:12:23Z

omments re: documentation have been ad

@jukkar yes for sure... looking for json dependency PR or alternative

github-actions · 2024-09-26T00:32:21Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions · 2024-11-26T00:35:52Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

kartben · 2024-12-11T01:11:04Z

@ssekar15 I would suggest putting this PR In draft mode if it's not ready yet. This makes it clearer that it doesn't require attention from reviewers. Thanks!

github-actions · 2025-04-06T00:39:35Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

zephyrbot added area: Samples Samples area: Networking area: Process labels Feb 8, 2024

zephyrbot requested review from jukkar, kartben, MaureenHelm, nashif, rlubos, ssharks, stephanosio and tbursztyka February 8, 2024 11:14

zephyrbot assigned kartben Feb 8, 2024

zephyrbot added manifest manifest-json-c DNM This PR should not be merged (Do Not Merge) labels Feb 8, 2024

ssekar15 force-pushed the ocpp_upstream branch from f83d4ff to 9bcf891 Compare February 8, 2024 11:15

zephyrbot removed manifest manifest-json-c labels Feb 8, 2024

ssekar15 changed the title ~~Ocpp upstream~~ [Draft] OCPP native stack Feb 8, 2024

zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Feb 8, 2024

parthitce mentioned this pull request Feb 8, 2024

Open Charge Point Protocol (OCPP) native implementation #58878

Open

jukkar reviewed Feb 8, 2024

View reviewed changes

rlubos reviewed Feb 8, 2024

View reviewed changes

lib/CMakeLists.txt Outdated Show resolved Hide resolved

lib/ocpp/Kconfig Outdated Show resolved Hide resolved

lib/ocpp/include/ocpp_i.h Outdated Show resolved Hide resolved

ssekar15 force-pushed the ocpp_upstream branch from 9bcf891 to 85b37ad Compare February 12, 2024 06:32

ssekar15 changed the title ~~[Draft] OCPP native stack~~ OCPP 1.6 native stack Feb 12, 2024

ssekar15 force-pushed the ocpp_upstream branch 2 times, most recently from aa9e763 to e1b137b Compare February 12, 2024 12:34

doc: ocpp: Describe Open Charge Point Protocol (OCPP) support

a0b8948

Describe OCPP Charge Point (CP) support and illustrate how to implement CP sample. Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

ssekar15 force-pushed the ocpp_upstream branch from 985b811 to 37a36d4 Compare May 20, 2024 09:07

ssekar15 and others added 5 commits May 21, 2024 12:13

tests: net: ocpp: Add test suit for OCPP lib

33eb0b9

Add test suit for OCPP lib with one complete charging session with a random meter values. Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

samples: net: ocpp: Charge Point test sample

54d3e73

A test sample for ocpp charge point with 2 connectors, central system steve server is used with test setup (public available) Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

MAINTAINERS: Add Open Charge Point Protocol (OCPP) lib

7549161

add code owner for OCPP native stack Signed-off-by: Saravanan Sekar <saravanan@linumiz.com>

MAINTAINERS.yml: Add json-c modules

756ec3f

This commit adds the new external json-c modules to the MAINTAINERS.yml file. Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>

ssekar15 force-pushed the ocpp_upstream branch from 37a36d4 to 756ec3f Compare May 21, 2024 06:44

ssekar15 requested a review from jukkar May 21, 2024 10:36

github-actions bot added the Stale label Jul 27, 2024

github-actions bot removed the Stale label Jul 28, 2024

github-actions bot added the Stale label Sep 26, 2024

jukkar removed the Stale label Sep 26, 2024

github-actions bot added the Stale label Nov 26, 2024

github-actions bot closed this Dec 10, 2024

ssekar15 reopened this Dec 10, 2024

github-actions bot removed the Stale label Dec 11, 2024

fabiobaltieri added DNM (manifest) This PR should not be merged (controlled by action-manifest) and removed DNM This PR should not be merged (Do Not Merge) labels Feb 4, 2025

github-actions bot added the Stale label Apr 6, 2025

parthitce removed the Stale label Apr 7, 2025

ssekar15 marked this pull request as draft April 7, 2025 06:05

		fn = ctx->cfn[UnlockConnector];
		fn(buf, sizeof(buf), resp, uid);

OCPP 1.6 native stack #68739

Are you sure you want to change the base?

OCPP 1.6 native stack #68739

Uh oh!

Conversation

ssekar15 commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Feb 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jukkar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jukkar Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

ssekar15 Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jukkar commented Feb 8, 2024

Uh oh!

rlubos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ssekar15 commented Feb 12, 2024

Uh oh!

github-actions bot commented Jul 27, 2024

Uh oh!

jukkar commented Jul 27, 2024

Uh oh!

ssekar15 commented Jul 27, 2024

Uh oh!

github-actions bot commented Sep 26, 2024

Uh oh!

github-actions bot commented Nov 26, 2024

Uh oh!

kartben commented Dec 11, 2024

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

Uh oh!

ssekar15 commented Feb 8, 2024 •

edited

Loading

zephyrbot commented Feb 8, 2024 •

edited

Loading