Skip to content

Conversation

@ulfalizer
Copy link
Contributor

Update Kconfiglib to upstream revision 7245bad9ebb58 (+ local Zephyr
modifications), to get the following improvements/fixes in:

  • Print a warning if an int or hex symbol is assigned a value that lies
    outside an active 'range' constraint.

  • Turn 'FOO' into a link in 'select FOO' when generating the Kconfig
    reference documentation.

  • Parenthesize '&&' expressions within '||' expressions --
    (A && B) || (C && D) is more readable than A && B || C && D.

The final two fixes will only be visible once the fix for #5622 gets in.

Fixes #6749
Fixes #6844

Origin: https://github.com/zephyrproject-rtos/Kconfiglib/tree/zephyr

Signed-off-by: Ulf Magnusson ulfalizer@gmail.com

Update Kconfiglib to upstream revision 7245bad9ebb58 (+ local Zephyr
modifications), to get the following improvements/fixes in:

 - Print a warning if an int or hex symbol is assigned a value that lies
   outside an active 'range' constraint.

 - Turn 'FOO' into a link in 'select FOO' when generating the Kconfig
   reference documentation.

 - Parenthesize '&&' expressions within '||' expressions --
   (A && B) || (C && D) is more readable than A && B || C && D.

The final two fixes will only be visible once the fix for zephyrproject-rtos#5622 gets in.

Fixes zephyrproject-rtos#6749
Fixes zephyrproject-rtos#6844

Origin: https://github.com/zephyrproject-rtos/Kconfiglib/tree/zephyr

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
@ulfalizer
Copy link
Contributor Author

CC @carlescufi

@ulfalizer
Copy link
Contributor Author

This newer version generates some new warnings related to selecting choice symbols (which is a no-op). I'll send a separate PR that removes the selects. It might be hard for me to guess what the intent was though.

warning: the choice symbol GPIO_DW_0_IRQ_SHARED (defined at drivers/gpio/Kconfig.dw:65) is selected by the following symbols, which has no effect: 
 - GPIO_DW_0 (defined at drivers/gpio/Kconfig.dw:40, arch/x86/soc/intel_quark/quark_x1000/Kconfig.defconfig.series:120, boards/arc/em_starterkit/Kconfig.defconfig:14)
warning: the choice symbol MCUBOOT_IMG_MANAGER (defined at subsys/dfu/Kconfig:29) is selected by the following symbols, which has no effect: 
 - MCUMGR_CMD_IMG_MGMT (defined at ext/lib/mgmt/mcumgr/cmd/img_mgmt/Kconfig:18)
warning: the choice symbol ENTROPY_DEVICE_RANDOM_GENERATOR (defined at subsys/random/Kconfig:41) is selected by the following symbols, which has no effect: 
 - BT_LL_SW (defined at subsys/bluetooth/controller/Kconfig:24)
 - ENTROPY_NATIVE_POSIX (defined at drivers/entropy/Kconfig.native_posix:2)
 - ENTROPY_MCUX_TRNG (defined at drivers/entropy/Kconfig.mcux:17, arch/arm/soc/nxp_kinetis/kwx/Kconfig.defconfig.mkw40z4:62, arch/arm/soc/nxp_kinetis/kwx/Kconfig.defconfig.mkw41z4:62)
 - ENTROPY_MCUX_RNGA (defined at drivers/entropy/Kconfig.mcux:7, arch/arm/soc/nxp_kinetis/k6x/Kconfig.defconfig.mk64f12:79, arch/arm/soc/nxp_kinetis/kwx/Kconfig.defconfig.mkw2xd512:84)
warning: the choice symbol MBEDTLS_BUILTIN (defined at ext/lib/crypto/mbedtls/Kconfig:33) is selected by the following symbols, which has no effect: 
 - CRYPTO_MBEDTLS_SHIM (defined at drivers/crypto/Kconfig:71)

@codecov-io
Copy link

Codecov Report

Merging #6848 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6848      +/-   ##
==========================================
+ Coverage   54.89%   54.89%   +<.01%     
==========================================
  Files         449      449              
  Lines       43328    43328              
  Branches     8157     8157              
==========================================
+ Hits        23785    23786       +1     
+ Misses      16241    16240       -1     
  Partials     3302     3302
Impacted Files Coverage Δ
samples/philosophers/src/main.c 98.43% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb05df...a42ba01. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Kconfiglib to improve generated documentation kconfig: The error message is misleading when values are out-of-range

3 participants