doc: Add gmtime_r() to rule A.5 exceptions #68414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmtime_r() has been in the minimal libc for years, however it was not added to expcetions due to an overlook. In order to do this however, it has to be moved first to the common libc area, so that it's available to any libc that may not implement it. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
According to commit 400c1fa which introduced rule A.5 to the coding guidelines, the initial exception list was based on the non-standard function availability in minimal libc. gmtime_r() however, has not been included to the list, although it's present in minimal libc since 3e8df8b. This commit fixes this, by adding gmtime_r() to the rule A.5 exception list. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
zephyrbot
added
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
cfriedt,
jfischer-no,
kartben,
keith-packard,
keith-zephyr,
nashif and
stephanosio
cfriedt
approved these changes
Feb 1, 2024
|
will need to update picolibc and the SDK for this. Is this going to land before the release? |
We will need to target the next release since there is not enough time to get that done. |
stephanosio
approved these changes
Feb 2, 2024
|
@stephanosio should we just merge this? Both CI checks failures are false positives, and there is no hard need to wait for a new SDK release containing the latest pico, as the code which uses it sets the macros it needs today. Worse case, in the meanwhile, new code using it would see a build warning if those are not set. |
|
Scancode and compliance check failures are false positives. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
gmtime_r()to rule's A.5 exception list, and move its implementation to common libc area, as per @stephanosio comment in #68003.Fixes #68003
Fixes #68056