Bluetooth: Mesh: Remove relay sets config for adv #65043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingaoM
force-pushed
the
rm_config
branch
2 times, most recently
from
9849714 to
e0cba97
Compare
Separate queue should also used for lagecy adv, due to when local queue has adv buf, k_poll will process local queue. Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
PavelVPV
previously approved these changes
Nov 10, 2023
alxelax
reviewed
Nov 10, 2023
Contributor
alxelax
left a comment
alxelax
left a comment
There was a problem hiding this comment.
LGTM just suggestion how to fix bsim on more reliable manner.
Please look at my comment.
This is to increase probability of reception of responses (Config Status messages) from the node when the provisioner sends a Set message and the node response with a Status message at the same time so that the message collide. Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
PavelVPV
approved these changes
Nov 14, 2023
alxelax
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate queue should also used for lagecy adv or extend adv(without enable relay sets), due to when local queue has adv buf,
k_pollwill process local queue at priority, and relay queue should be delay for sending.