.gitlint: de-duplicate defaults with zephyr_commit_rules.py #62876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
galak,
jfischer-no,
keith-zephyr,
nashif and
stephanosio
marc-hb
requested review from
dbaluta,
fabiobaltieri,
edersondisouza and
mbolivar-ampere
keith-zephyr
previously approved these changes
Sep 20, 2023
We don't need to have two different sets of Zephyr-specific default values overriding one another, it's confusing. Note this commit makes NO functional change, the effective defaults stay the same. It does however make it easier to change defaults in the future. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
dedup-gitlint-defaults
branch
from
16101a3
to
18a1f45
Compare
|
Thanks @keith-zephyr ! I just spotted a typo in a comment and force-pushed 10 min after you approved :-( Could you re-approve? Sorry for the inconvenience. |
keith-zephyr
approved these changes
Sep 20, 2023
edersondisouza
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to have two different sets of Zephyr-specific default values overriding one another, it's confusing.
Note this commit makes NO functional change, the effective defaults stay the same. It does however make it easier to change defaults in the future.