[Backport v3.3-branch] drivers: can: stm32: correct timing_max parameters #61538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timing_max parameters defined in the stm32 bxcan driver don't match the register description in the reference manuals. - sjw does have only 2 bits representing 1 to 4 tq. - phase_seg1 and phase_seg2 max is one tq higher. I have checked the following reference manuals and all match: - RM0090: STM32F405, F415, F407, F417, F427, F437 AND F429 - RM0008: STM32F101, F102, F103, F105, F107 advanced arm-based mcus - RM0351, RM0394: all STM32L4 - RM0091: all STM32F0 with CAN support Signed-off-by: Thomas Stranger <thomas.stranger@outlook.com> (cherry picked from commit cec279b)
zephyrbot
requested review from
alexanderwachter and
henrikbrixandersen
as code owners
zephyrbot
added
Backport
zephyrbot
requested review from
ABOSTM,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
karstenkoenig,
martinjaeger and
str4t0m
martinjaeger
approved these changes
Aug 16, 2023
henrikbrixandersen
approved these changes
Aug 16, 2023
erwango
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport cec279b from #61449.
Fixes #61451