Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: flash: spi_nor: select largest valid erase operation #60943

Merged

Conversation

Crzyrndm
Copy link
Contributor

@Crzyrndm Crzyrndm commented Jul 28, 2023

The spi_nor erase op selection was based on the alignment of the end of the region to be erased. This prevented larger erase operations being selected in many cases

Closes #60904

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Crzyrndm, and thank you very much for your first pull request to the Zephyr project!

A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊

@Crzyrndm
Copy link
Contributor Author

Crzyrndm commented Jul 29, 2023

Test failure is unrelated? Seems like #60941

@cfriedt
Copy link
Member

cfriedt commented Jul 29, 2023

Test failure is unrelated? Seems like #60941

Was it the tlsTransport? That still seems to be somewhat problematic, but I am looking into it.

E.g.
https://github.com/zephyrproject-rtos/zephyr/actions/runs/5697038294/job/15443170454?pr=60942#step:13:282

@Laczen
Copy link
Collaborator

Laczen commented Jul 29, 2023

@Crzyrndm could you add closes #60904 to your commit message.

@Crzyrndm
Copy link
Contributor Author

@Crzyrndm could you add closes #60904 to your commit message.

Done

@Crzyrndm
Copy link
Contributor Author

Test failure again unrelated?

@de-nordic de-nordic added backport v2.7-branch Request backport to the v2.7-branch backport v3.2-branch backport v3.4-branch Backport to the v3.4-branch labels Jul 31, 2023
The spi_nor erase op selection was based on the alignment of the end of
the region to be erased. This prevented larger erase operations being
selected in many cases

Closes zephyrproject-rtos#60904

Signed-off-by: Joshua Crawford <joshua.crawford@levno.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Crzyrndm!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Flash backport v2.7-branch Request backport to the v2.7-branch backport v3.4-branch Backport to the v3.4-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spi_nor Erase operation selection is excessively conservative
6 participants