-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TI J721e R5 and BeagleBone AI64 R5 initial support #59191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @slpp95prashanth, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
2a833bc
to
352efc5
Compare
b248774
to
a17f9b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that filenames in the board directory should match the board name. I think that's a convention.
173ac96
to
ac938e2
Compare
513e99c
to
6107782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite strongly opinionated about adding support in-tree for a board without an interrupt controller and only with the hello world
sample running. The feature set for a new SoC / board should be enough to at least pass the kernel tests.
72495d1
to
c7687bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tired of this.
Did you at least try to compile this?
# west build -b beagle_bbai64_r5 samples/hello_world -p
dts/arm/ti/j721e.dtsi:10:10: fatal error: zephyr/dt-bindings/interrupt-controller/ti-vim.h: No such file or directory
10 | #include <zephyr/dt-bindings/interrupt-controller/ti-vim.h>
I honestly feel you are wasting mine and maintainers time here. I'm going to remove myself from this PR.
soc/arm/ti_k3/j721e/soc.c
Outdated
static int j721e_init(void) | ||
{ | ||
return 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove if not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlocaione j721e_init is passed to SYS_INIT as a initialisation function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, drop if empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pass NULL as a first argument to SYS_INIT()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the point of a no-op SYS_INIT...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing SYS_INIT() and j721e_init().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slpp95prashanth , sorry for the late response, but you will need to atleast unlock the CTRL MMR regions during, all the necessary regions might not always be unlocked by bootloader for you.
See https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/arm/ti_k3/am62x_m4/soc.c#L47
@carlocaione I apologize, but this PR depends on #60856 and #61020 which is mentioned in #59191 (comment). I do not have any intention to waste yours and maintainers time, please do not say like that. |
Add initial Device Tree support for the TI J721E SoC series. TRM for J721e https://www.ti.com/lit/zip/spruil1 File: spruil1c.pdf Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
|
||
Steps to flash the image | ||
------------------------ | ||
The Example shows how to load an image on Cortex R5FSS0_CORE0 on J721e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is example capitalized?
I should have read this section before commenting above. I was thinking you were talking about west flash
. Can you implement west flash
to flash the image and provide documentation on what it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can implement west flash for this.
| Copy Zephyr image to the /lib/firmware/ directory. | ||
| ``cp build/zephyr/zephyr.elf /lib/firmware/`` | ||
| | ||
| Ensure the Core is not running. | ||
| ``echo stop > /sys/class/remoteproc/remoteproc18/state`` | ||
| | ||
| Configuring the image name to the remoteproc module. | ||
| ``echo zephyr.elf > /sys/class/remoteproc/remoteproc18/firmware`` | ||
| | ||
| Once the image name is configured, send the start command. | ||
| ``echo start > /sys/class/remoteproc/remoteproc18/state`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not implement a proper runner so you can west flash
?
@@ -9,7 +9,6 @@ config SOC_FAMILY_TI_K3 | |||
bool | |||
|
|||
if SOC_FAMILY_TI_K3 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KarthikL1729 can you please update this?
config PINCTRL | ||
default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1, please make sure drivers select this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmarull should I remove this from here, and add "select PINCTRL" in drivers.
Or select at both places.
soc/arm/ti_k3/j721e/soc.c
Outdated
static int j721e_init(void) | ||
{ | ||
return 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, drop if empty
Add initial SoC support for the TI J721E SoC series Cortex-R5 core. TRM for J721e https://www.ti.com/lit/zip/spruil1 File: spruil1c.pdf Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
Add initial BeagleBone AI-64 support BeagleBone AI_64 https://beagleboard.org/ai-64 Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
c7687bd
to
08f3bcc
Compare
I am adding west flash support, I will try to add ASAP. |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This PR (non-working port) adds device tree and soc support for TI J721e_r5 and Beaglebone AI64 board support for hello_world application.
TRM for J721e https://www.ti.com/lit/zip/spruil1
File: spruil1c.pdf
BeagleBone AI_64 https://beagleboard.org/ai-64
Signed-off-by: Prashanth S slpp95prashanth@yahoo.com