Add TI J721e R5 and BeagleBone AI64 R5 initial support #59191
Conversation
slpp95prashanth
requested review from
nashif,
MaureenHelm,
galak and
ioannisg
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @slpp95prashanth, and thank you very much for your first pull request to the Zephyr project!
A project maintainer just triggered our CI pipeline to run it against your PR and ensure it's compliant and doesn't cause any issues. You might want to take this opportunity to review the project's Contributor Expectations and make any updates to your pull request if necessary. 😊
slpp95prashanth
force-pushed
the
zephyr
branch
4 times, most recently
from
2a833bc
to
352efc5
Compare
vaishnavachath
changed the title
slpp95prashanth
force-pushed
the
zephyr
branch
3 times, most recently
from
b248774
to
a17f9b7
Compare
slpp95prashanth
force-pushed
the
zephyr
branch
3 times, most recently
from
173ac96
to
ac938e2
Compare
zephyrbot
added
area: Interrupt Controller
area: Devicetree Binding
slpp95prashanth
force-pushed
the
zephyr
branch
2 times, most recently
from
513e99c
to
6107782
Compare
slpp95prashanth
force-pushed
the
zephyr
branch
from
72495d1
to
c7687bd
Compare
There was a problem hiding this comment.
I'm tired of this.
Did you at least try to compile this?
# west build -b beagle_bbai64_r5 samples/hello_world -p
dts/arm/ti/j721e.dtsi:10:10: fatal error: zephyr/dt-bindings/interrupt-controller/ti-vim.h: No such file or directory
10 | #include <zephyr/dt-bindings/interrupt-controller/ti-vim.h>
I honestly feel you are wasting mine and maintainers time here. I'm going to remove myself from this PR.
soc/arm/ti_k3/j721e/soc.c
Outdated
| static int j721e_init(void) | ||
| { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
@carlocaione j721e_init is passed to SYS_INIT as a initialisation function.
There was a problem hiding this comment.
Can we pass NULL as a first argument to SYS_INIT()?
There was a problem hiding this comment.
what's the point of a no-op SYS_INIT...?
There was a problem hiding this comment.
Removing SYS_INIT() and j721e_init().
There was a problem hiding this comment.
@slpp95prashanth , sorry for the late response, but you will need to atleast unlock the CTRL MMR regions during, all the necessary regions might not always be unlocked by bootloader for you.
See https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/arm/ti_k3/am62x_m4/soc.c#L47
carlocaione
requested review from
carlocaione
and removed request for
carlocaione
@carlocaione I apologize, but this PR depends on #60856 and #61020 which is mentioned in #59191 (comment). I do not have any intention to waste yours and maintainers time, please do not say like that. |
Add initial Device Tree support for the TI J721E SoC series. TRM for J721e https://www.ti.com/lit/zip/spruil1 File: spruil1c.pdf Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
|
|
||
| Steps to flash the image | ||
| ------------------------ | ||
| The Example shows how to load an image on Cortex R5FSS0_CORE0 on J721e. |
There was a problem hiding this comment.
Why is example capitalized?
I should have read this section before commenting above. I was thinking you were talking about west flash. Can you implement west flash to flash the image and provide documentation on what it does?
There was a problem hiding this comment.
Yes, I can implement west flash for this.
| | Copy Zephyr image to the /lib/firmware/ directory. | ||
| | ``cp build/zephyr/zephyr.elf /lib/firmware/`` | ||
| | | ||
| | Ensure the Core is not running. | ||
| | ``echo stop > /sys/class/remoteproc/remoteproc18/state`` | ||
| | | ||
| | Configuring the image name to the remoteproc module. | ||
| | ``echo zephyr.elf > /sys/class/remoteproc/remoteproc18/firmware`` | ||
| | | ||
| | Once the image name is configured, send the start command. | ||
| | ``echo start > /sys/class/remoteproc/remoteproc18/state`` |
There was a problem hiding this comment.
why not implement a proper runner so you can west flash?
| @@ -9,7 +9,6 @@ config SOC_FAMILY_TI_K3 | |||
| bool | |||
|
|
|||
| if SOC_FAMILY_TI_K3 | |||
|
|
|||
There was a problem hiding this comment.
@KarthikL1729 can you please update this?
| config PINCTRL | ||
| default y |
There was a problem hiding this comment.
-1, please make sure drivers select this
There was a problem hiding this comment.
@gmarull should I remove this from here, and add "select PINCTRL" in drivers.
Or select at both places.
soc/arm/ti_k3/j721e/soc.c
Outdated
| static int j721e_init(void) | ||
| { | ||
| return 0; | ||
| } |
Add initial SoC support for the TI J721E SoC series Cortex-R5 core. TRM for J721e https://www.ti.com/lit/zip/spruil1 File: spruil1c.pdf Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
Add initial BeagleBone AI-64 support BeagleBone AI_64 https://beagleboard.org/ai-64 Signed-off-by: Prashanth S <slpp95prashanth@yahoo.com>
slpp95prashanth
force-pushed
the
zephyr
branch
from
c7687bd
to
08f3bcc
Compare
|
I am adding west flash support, I will try to add ASAP. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
This PR (non-working port) adds device tree and soc support for TI J721e_r5 and Beaglebone AI64 board support for hello_world application.
TRM for J721e https://www.ti.com/lit/zip/spruil1
File: spruil1c.pdf
BeagleBone AI_64 https://beagleboard.org/ai-64
Signed-off-by: Prashanth S slpp95prashanth@yahoo.com