-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: console: uart_console.c: suggestion to add new line for unix or linux host #51805
drivers: console: uart_console.c: suggestion to add new line for unix or linux host #51805
Conversation
4a138ea
to
f2bc377
Compare
Hi, any updates? How do i add active reviewers? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the contribution guide on writing commit messages: https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines
Also, have you tried this on both Linux and Windows terminals? Windows' line breaks are \r\n
which means this changes will match the same line twice.
ba0acb2
to
ccd4b4a
Compare
Hi @dcpleung, thank you for the review. I do not have a window terminal, but i am able to test However, the double line problem will still occur, if the terminal encodes enter key as Is there a general define for terminal endings? |
Since Windows is doing |
Please fix the CI errors. |
Hi @dcpleung, thank you for the feedback. i don't know how to fix that error. Even if i revert my changes, the error is still there. I have pulled locally: The test gives different result for each excution.
or sometimes kernel panic after the test is executed.
on rare occasion, the test is passed:
I am not sure if this is because of my low spec ubuntu vm. Some fix is introduced in at #38777. I would suggest to remove the test suite, until it is stable. |
Add case \n, so that new line from unix or linux host can be detected. Signed-off-by: Shun Jing Goh <shun.jing.goh@gmail.com>
ccd4b4a
to
b7feb0f
Compare
This is a suggestion to use console_getline() for uart, that is connected to pc with unix or linux OS.
Add case '\n', so that new line can be detected.
Signed-off-by shun.jing.goh@gmail.com