10-bit addressing not supported by I2C slave driver for STM32 target #51060

[AshwiniMShinde-eaton]

I2C: Add 10-bit addressing support for I2C slave driver for STM32 target.
This patch adds changes that will help to register STM32 target as a slave with 10-bit addressing enabled

[erwango]

Thanks for sharing. Some parts to fix.

Also, it would be nice to return an error in case 10bits address mode is tried to be configured for slave2 as it is not supported. For instance, in slave 2 code, add:

		if (data->slave_cfg->flags == I2C_SLAVE_FLAGS_ADDR_10_BITS)	{
			return -EVINVAL;
		}

[erwango]

Your pull request does not conform with Zephyr contribution guidelines. For reference, I'd advise you to check:

• Contribution guidelines on docs.zephyrproject.org
• Great presentation dealing with "the best way to get your patches merged" and the related Slides
• Coding Guidelines bot results reported below.

Please:

• Check your commit message. It should conform to the following template:

<dir>: <dir>: <Title summarizing the change>

<A description useful to the reader>

Signed-off-by: foo <foo@bar.baz>

• Remove the merge commit(s)
• We don't merge fixup commits. Please squash all fixes in the corresponding commits

[AshwiniMShinde-eaton]

Your pull request does not conform with Zephyr contribution guidelines. For reference, I'd advise you to check:

• Contribution guidelines on docs.zephyrproject.org
• Great presentation dealing with "the best way to get your patches merged" and the related Slides
• Coding Guidelines bot results reported below.

Please:

• Check your commit message. It should conform to the following template:

<dir>: <dir>: <Title summarizing the change>

<A description useful to the reader>

Signed-off-by: foo <foo@bar.baz>

• Remove the merge commit(s)
• We don't merge fixup commits. Please squash all fixes in the corresponding commits

@erwango I've removed my previous commits and pushed the commit that follows all the guidelines. The checks are waiting for approval. Can you please approve?

[AshwiniMShinde-eaton]

@erwango @teburd @FRASTM Is this PR good to merge once all the checks pass?
I just wanted confirmation from you all that there are no further changes required from my side

[teburd]

Please don't force push unless you are making changes, it removes the CI check passes and approvals

[AshwiniMShinde-eaton]

Please don't force push unless you are making changes, it removes the CI check passes and approvals

I've been rebasing(Using rebase branch button here) from time to time as it shows "This branch is out-of-date" with the base branch. When I get all the approvals and all checks pass then merging gets blocked as it requires rebasing. This cycle goes on and its been long time I haven't been able to get my PR merged. Is this the right way? Is there any way to avoid this or did I miss anything?

[prayassamriya]

@AshwiniMShinde-eaton, May be you can request primary approvers/module owners to merge if they think it meets their expectations. due to time zone difference this issue may be surfacing again and again. what's your thoughts @FRASTM , @erwango and others?

[teburd]

Please don't force push unless you are making changes, it removes the CI check passes and approvals

I've been rebasing(Using rebase branch button here) from time to time as it shows "This branch is out-of-date" with the base branch. When I get all the approvals and all checks pass then merging gets blocked as it requires rebasing. This cycle goes on and its been long time I haven't been able to get my PR merged. Is this the right way? Is there any way to avoid this or did I miss anything?

So long as there are no conflicts, its ok.

[AshwiniMShinde-eaton]

Please don't force push unless you are making changes, it removes the CI check passes and approvals

I've been rebasing(Using rebase branch button here) from time to time as it shows "This branch is out-of-date" with the base branch. When I get all the approvals and all checks pass then merging gets blocked as it requires rebasing. This cycle goes on and its been long time I haven't been able to get my PR merged. Is this the right way? Is there any way to avoid this or did I miss anything?

So long as there are no conflicts, its ok.

@teburd Could you(or anyone who is authorized to merge this PR) please help to get this merged?

[teburd]

Please don't force push unless you are making changes, it removes the CI check passes and approvals

I've been rebasing(Using rebase branch button here) from time to time as it shows "This branch is out-of-date" with the base branch. When I get all the approvals and all checks pass then merging gets blocked as it requires rebasing. This cycle goes on and its been long time I haven't been able to get my PR merged. Is this the right way? Is there any way to avoid this or did I miss anything?

So long as there are no conflicts, its ok.

@teburd Could you(or anyone who is authorized to merge this PR) please help to get this merged?

When the release managers see this is ready to merge, which means there are at least 2 approvals including the assignee, and green CI, they merge it. There's filters the release managers use to periodically find PRs ready to merge and do so.