Skip to content

Conversation

benys
Copy link
Contributor

@benys benys commented Sep 22, 2022

The vl6180x is time of flight sensor. Sensor publish proximity and distance channel.

Signed-off-by: Kamil Serwus kserwus@gmail.com

@zephyrbot
Copy link

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_st zephyrproject-rtos/hal_st@cccbc24 (master) zephyrproject-rtos/hal_st#12 zephyrproject-rtos/hal_st#12/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label Sep 30, 2022
Comment on lines +15 to +20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert this to a devicetree property so it can be configured on a per-instance basis

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose this particular sleep duration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datasheet (https://www.st.com/resource/en/datasheet/vl6180x.pdf) said that device is ready after 1ms 400us.
So I assumes that after set new address we need to wait.
But I see at documentation that is any timeing information after this operation. I remove this and I test it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property needs a description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this sample generic to any TOF sensor and add it in a separate commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaureenHelm
Can you give me a little help - can you point me another generic sample?

For example:
So I has to change from vl6180x to tof? And define some other overloads?

I don't udnerstand :-(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See samples/sensor/accel_polling and samples/sensor/magn_polling

Comment on lines +7 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant and can be removed

@benys benys marked this pull request as draft November 18, 2022 07:21
The vl6180x is time of flight sensor. Sensor publish proximity and
distance channel.

Signed-off-by: Kamil Serwus <kserwus@gmail.com>
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 31, 2023
@github-actions github-actions bot closed this Feb 14, 2023
@seyednasermoravej
Copy link

Hi,
Why this changes aren't on the main Zephyr repository?
How can I use this driver?
Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Sensors Sensors DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_st Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants