-
Notifications
You must be signed in to change notification settings - Fork 8k
st: vl6180x: Driver for vl6180x #50517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
drivers/sensor/vl6180x/Kconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert this to a devicetree property so it can be configured on a per-instance basis
drivers/sensor/vl6180x/vl6180x.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you choose this particular sleep duration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Datasheet (https://www.st.com/resource/en/datasheet/vl6180x.pdf) said that device is ready after 1ms 400us.
So I assumes that after set new address we need to wait.
But I see at documentation that is any timeing information after this operation. I remove this and I test it.
dts/bindings/sensor/st,vl6180x.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property needs a description
samples/sensor/vl6180x/README.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this sample generic to any TOF sensor and add it in a separate commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaureenHelm
Can you give me a little help - can you point me another generic sample?
For example:
So I has to change from vl6180x to tof? And define some other overloads?
I don't udnerstand :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See samples/sensor/accel_polling
and samples/sensor/magn_polling
samples/sensor/vl6180x/prj.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
samples/sensor/vl6180x/prj.conf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant and can be removed
The vl6180x is time of flight sensor. Sensor publish proximity and distance channel. Signed-off-by: Kamil Serwus <kserwus@gmail.com>
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Hi, |
The vl6180x is time of flight sensor. Sensor publish proximity and distance channel.
Signed-off-by: Kamil Serwus kserwus@gmail.com