net: coap: Remove resource pointer NULL check #48483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the resource pointer NULL check inside the resource enumeration loop of the `coap_well_known_core_get` function because the expression `(resource + 1)` will never evaluate to NULL (aka. 0). This fixes the "comparison will always evaluate as ‘true’ for the pointer operand" warning generated by the GCC 12. Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
49 tasks
pdgendt
approved these changes
Jul 29, 2022
gmarull
approved these changes
Jul 29, 2022
nashif
approved these changes
Jul 29, 2022
carlescufi
approved these changes
Aug 1, 2022
rlubos
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the resource pointer NULL check inside the resource
enumeration loop of the
coap_well_known_core_getfunction because theexpression
(resource + 1)will never evaluate to NULL (aka. 0).This fixes the "comparison will always evaluate as ‘true’ for the
pointer operand" warning generated by the GCC 12.
Signed-off-by: Stephanos Ioannidis root@stephanos.io
p.s. In general, this function does not seem very sane to me (e.g. doing NULL check on an incremented pointer, potentially dereferencing beyond the resource array bounds), but fixing this is beyond the scope of this PR.