drivers: dma: Add GD32 DMA driver #47501

soburi · 2022-07-07T14:08:27Z

Add support for GD32 DMA

Signed-off-by: TOKITA Hiroshi tokita.hiroshi@gmail.com

I verified ths PR with tests/drivers/dma/loop_transfer with GD32VF103(longan_nano board).

drivers/dma/dma_gd32.c

drivers/dma/Kconfig.gd32

nandojve · 2022-07-09T16:51:32Z

drivers/dma/dma_gd32.c

+	}
+}
+
+static int gd32_dma_config(const struct device *dev, uint32_t channel, struct dma_config *dma_cfg)


Let's keep at 80 col

Currently, the clang-format setting is up to 100 columns(3f0e8dd).
Is this no good?

This code is formating with clang-format following instruction https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format.

Hi @soburi ,

There was an agreement to allow up to 100 col in code. This doesn't mean that we will follow it.
Zephyr still use Linux kernel coding style and we will keep it for GigaDevices. I point 2 exceptions that are OK to use more than 80 columns.

Please, reformat code to use 80 columns.

drivers/dma/dma_gd32.c

dts/riscv/gigadevice/gd32vf103.dtsi

tests/drivers/dma/loop_transfer/boards/longan_nano.overlay

cameled

This is a big step for the tansfer performence. Have a qiuck look, will try to run this on my gd32vf103v board latter.

drivers/dma/dma_gd32.c

cameled · 2022-07-22T10:14:29Z

For gd32f4xx series, only dma1 support m2m, and ~~should use multi-data mode~~

EDIT: m2m multi-data mode auto applied by hardware.

drivers/dma/dma_gd32.c

dts/arm/gigadevice/gd32f4xx/gd32f4xx.dtsi

tests/drivers/dma/loop_transfer/boards/gd32f450i_eval.overlay

tests/drivers/dma/loop_transfer/boards/gd32f450z_eval.overlay

tests/drivers/dma/loop_transfer/boards/gd32f470i_eval.overlay

drivers/dma/dma_gd32.c

drivers/dma/Kconfig.gd32

dts/arm/gigadevice/gd32e10x/gd32e10x.dtsi

nandojve · 2022-07-27T10:04:57Z

drivers/dma/dma_gd32.c

+	rcu_periph_clock_enable(cfg->rcu_periph_clock);
+
+	for (uint32_t i = 0; i < cfg->channels; i++) {
+		gd32_dma_interrupt_disable(cfg->reg, i, DMA_CHXCTL_FTFIE | GD32_DMA_INTERRUPT_ERRORS);


long lines...

-gd32_dma_interrupt_disable(cfg->reg, i, DMA_CHXCTL_FTFIE | GD32_DMA_INTERRUPT_ERRORS); +gd32_dma_interrupt_disable(cfg->reg, i, + DMA_CHXCTL_FTFIE | + GD32_DMA_INTERRUPT_ERRORS);

Completed all fixes.
Sorry for taking up your time, but please review.

cameled

LGTM, dma loop_transfer test passed on my gd32f450i_eval and gd32f350r_eval boards.

nandojve · 2022-07-30T10:40:07Z

drivers/dma/dma_gd32.c

+ * Register access functions
+ */
+
+static inline void gd32_dma_periph_increase_enable(uint32_t reg, dma_channel_enum ch)


Please, keep at 80col, rework all file.

Rerun clang-format with ColumnLimit: 80

If the clang format settings aren’t the style guide this is the inevitable issue. Please file an issue or PR against the clang format settings. The docs suggest running it, and the settings define a style that should make code fit the zephyr style and avoid exactly this discussion, if not it’s something that should be fixed.

drivers/dma/dma_gd32.c

dts/arm/gigadevice/gd32e10x/gd32e10x.dtsi

nandojve · 2022-07-30T11:40:36Z

drivers/dma/dma_gd32.c

+	}
+}
+
+static int gd32_dma_config(const struct device *dev, uint32_t channel, struct dma_config *dma_cfg)


Hi @soburi ,

There was an agreement to allow up to 100 col in code. This doesn't mean that we will follow it.
Zephyr still use Linux kernel coding style and we will keep it for GigaDevices. I point 2 exceptions that are OK to use more than 80 columns.

Please, reformat code to use 80 columns.

Add support for GD32 DMA Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Add DMA support for GD32 series. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Add configuration file for GD32 boards. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

teburd

looks like a well written driver, very nice

nandojve

Hi @soburi ,

Thank you for the patience. You made a very good job!

soburi · 2022-08-01T23:43:10Z

Hi, @nandojve , @teburd , @cameled

Thank you for your review.
It's been a long review, but it's not the last.
Please also #47504. 😃

soburi requested review from nashif, nandojve, kgugala and pgielda as code owners July 7, 2022 14:08

zephyrbot added area: Devicetree platform: GD32 GigaDevice area: DMA Direct Memory Access labels Jul 7, 2022

zephyrbot requested review from galak, gmarull, mbolivar-nordic and teburd July 7, 2022 14:09

zephyrbot assigned teburd Jul 7, 2022

soburi mentioned this pull request Jul 7, 2022

drivers: spi: gd32: Add support DMA transfer #47504

Merged

nandojve requested changes Jul 9, 2022

View reviewed changes

nandojve mentioned this pull request Jul 9, 2022

[RFC] GigaDevice Vendor Support #38657

Open

55 tasks

soburi force-pushed the gd32_dma branch 3 times, most recently from 235757b to 1689baa Compare July 16, 2022 16:02

soburi requested a review from nandojve July 16, 2022 16:19

cameled reviewed Jul 21, 2022

View reviewed changes

drivers/dma/dma_gd32.c Outdated Show resolved Hide resolved

drivers/dma/dma_gd32.c Outdated Show resolved Hide resolved

drivers/dma/dma_gd32.c Outdated Show resolved Hide resolved

cameled reviewed Jul 22, 2022

View reviewed changes

drivers/dma/dma_gd32.c Outdated Show resolved Hide resolved

cameled reviewed Jul 23, 2022

View reviewed changes

soburi force-pushed the gd32_dma branch from 1689baa to 45bba3b Compare July 23, 2022 17:20

cameled reviewed Jul 24, 2022

View reviewed changes

drivers/dma/dma_gd32.c Outdated Show resolved Hide resolved

cameled reviewed Jul 24, 2022

View reviewed changes

drivers/dma/dma_gd32.c Outdated Show resolved Hide resolved

nandojve requested changes Jul 24, 2022

View reviewed changes

drivers/dma/Kconfig.gd32 Outdated Show resolved Hide resolved

dts/arm/gigadevice/gd32e10x/gd32e10x.dtsi Outdated Show resolved Hide resolved

soburi force-pushed the gd32_dma branch 3 times, most recently from d446511 to 6a6c12b Compare July 26, 2022 22:11

nandojve requested changes Jul 27, 2022

View reviewed changes

soburi force-pushed the gd32_dma branch from 120b2aa to 7e02aa0 Compare July 27, 2022 10:10

soburi requested review from nandojve and cameled July 27, 2022 10:47

soburi force-pushed the gd32_dma branch from 7e02aa0 to 7f01a99 Compare July 28, 2022 13:23

cameled previously approved these changes Jul 29, 2022

View reviewed changes

nandojve reviewed Jul 30, 2022

View reviewed changes

soburi added 3 commits July 30, 2022 21:47

drivers: dma: Add GD32 DMA driver

14acad1

Add support for GD32 DMA Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

dts: arm: gigadevice: Add DMA configuration

7fca5d5

Add DMA support for GD32 series. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

tests: dma: loop_transfer: Add GD32 series to loop_transfer test

1941ebf

Add configuration file for GD32 boards. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

soburi dismissed cameled’s stale review via 042a9d2 July 30, 2022 12:53

soburi force-pushed the gd32_dma branch from 7f01a99 to 042a9d2 Compare July 30, 2022 12:53

zephyrbot added the area: RISCV RISCV Architecture (32-bit & 64-bit) label Jul 30, 2022

zephyrbot requested review from edersondisouza, fkokosinski, katsuster, mgielda and tgorochowik July 30, 2022 12:53

soburi force-pushed the gd32_dma branch from 042a9d2 to 1941ebf Compare July 30, 2022 13:12

soburi requested review from cameled and nandojve July 30, 2022 13:42

teburd approved these changes Aug 1, 2022

View reviewed changes

nandojve approved these changes Aug 1, 2022

View reviewed changes

nandojve added this to the v3.2.0 milestone Aug 1, 2022

cameled approved these changes Aug 2, 2022

View reviewed changes

carlescufi merged commit d5ab3ee into zephyrproject-rtos:main Aug 2, 2022

soburi deleted the gd32_dma branch August 2, 2022 07:17

soburi restored the gd32_dma branch August 2, 2022 07:17

soburi deleted the gd32_dma branch August 2, 2022 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: dma: Add GD32 DMA driver #47501

drivers: dma: Add GD32 DMA driver #47501

soburi commented Jul 7, 2022 •

edited

Loading

nandojve Jul 9, 2022

soburi Jul 16, 2022

nandojve Jul 30, 2022

cameled left a comment

cameled commented Jul 22, 2022 •

edited

Loading

nandojve Jul 27, 2022

soburi Jul 27, 2022

cameled left a comment •

edited

Loading

nandojve Jul 30, 2022

soburi Jul 30, 2022

teburd Aug 1, 2022

nandojve Aug 1, 2022

nandojve Jul 30, 2022

teburd left a comment

nandojve left a comment

soburi commented Aug 1, 2022 •

edited

Loading

drivers: dma: Add GD32 DMA driver #47501

drivers: dma: Add GD32 DMA driver #47501

Conversation

soburi commented Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cameled left a comment

Choose a reason for hiding this comment

cameled commented Jul 22, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cameled left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

teburd left a comment

Choose a reason for hiding this comment

nandojve left a comment

Choose a reason for hiding this comment

soburi commented Aug 1, 2022 • edited Loading

soburi commented Jul 7, 2022 •

edited

Loading

cameled commented Jul 22, 2022 •

edited

Loading

cameled left a comment •

edited

Loading

soburi commented Aug 1, 2022 •

edited

Loading