Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soc: arc: remove <soc.h> usage #46585

Merged
merged 19 commits into from
Aug 3, 2022
Merged

soc: arc: remove <soc.h> usage #46585

merged 19 commits into from
Aug 3, 2022

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Jun 15, 2022 •
edited
Loading

<soc.h> has traditionally been used as a proxy to HAL headers,
register definitions, etc. Nowadays, <soc.h> is anarchy. It serves a
different purpose depending on the SoC. In some cases, it includes HALs,
in some others, it works as a header sink/proxy (for no good reason), as
a register definition when there's no HAL (bypassing the purpose of DT in some cases…).
To make things worse, it is being included in code that is, in theory, non-SoC specific.

This patch is part of a series intended to improve the situation by
removing <soc.h> usage when not needed, and by eventually removing it.

NOTE: I have zero ARC knowledge, so some patches may not contain the best solution (specially the DT part).

Related to #46147 and #41543

@gmarull gmarull requested a review from stephanosio June 15, 2022 14:46
@gmarull gmarull force-pushed the arc-soc-cleanup branch 5 times, most recently from d35a93e to 1a670e1 Compare June 16, 2022 09:44
andyross
andyross previously approved these changes Jun 16, 2022
View reviewed changes
@gmarull
soc: arc: snps_arc_iot: move SYSCLK_DEFAULT_IOSC_HZ to sysconf
b9043d9 
sysconf source file is the only user of such definition, so move it
there.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_emsdp/k: remove unused SYSCLK_DEFAULT_IOSC_HZ
50a977a 
The definition is not used, so remove it.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_arc_iot: delete unused soc_irq.h file
04d5153 
The definitions provided by this file seem to be unused throughout the
tree, so remove it.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_arc_iot: define sysconf in DT
e458486 
sysconf base address was hardcoded in <soc.h>. Create a new compatible
and define it in Devicetree, where hardware needs to be described.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_emsk/nsim: remove unused definitions
61350ca 
Remove definitions not used in any C unit throughout the tree.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: define ICI in DT
9bb1b02 
ICI (Inter-Core Interrupt Unit) interrupts and priorities were hardcoded
in C files. This patch moves this information to Devicetree and updates
code to make use of it.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
drivers: arc/designware: remove unused <soc.h>
38b171c 
The <soc.h> header is not required by a few ARC/Designware drivers, so
remove it.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
arch: arc: remove unused <soc.h>
487674b 
Header was not used, so remove it.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
boards: arc: remove unused <soc.h>
7df25bb 
Header was not used, so remove it. Add other necessary includes as part
of the removal.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_nsim: s/soc.c/smp.c and compile only if CONFIG_SMP=y
c1e98ac 
The soc.c source only contains code relevant to SMP, and in fact, it is
a file that is left empty when pre-processed from a compiler perspective
if CONFIG_SMP=n. This change renames it to smp.c to make it clear it
contains SMP related code, and, it compiles it conditionally to
CONFIG_SMP=y.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_nsim: fix include list
97d3cc5 
Include only what is needed.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_emsk: remove empty soc.c
e864f23 
soc.c was empty, so just delete it.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: snps_emsk: fix include list
962a41b 
Include only what is needed in soc_config.c

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull
soc: arc: remove unused <soc.h> files
020b07f 
The ARC <soc.h> headers are no longer used, so they can be removed.
Refer to the previous commits for more context.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull gmarull removed DNM This PR should not be merged (Do Not Merge) labels Jul 15, 2022
@gmarull
Copy link
Member Author

gmarull commented Jul 15, 2022

@evgeniy-paltsev @ruuddw please check latest changes

ruuddw
ruuddw approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@ruuddw ruuddw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(but let's wait for Evgeniy's final testing/ack)

@gmarull gmarull mentioned this pull request Jul 20, 2022
Merged
@gmarull
Copy link
Member Author

gmarull commented Aug 2, 2022

@evgeniy-paltsev gentle ping

@evgeniy-paltsev
Copy link
Collaborator

Hi @gmarull,

I've tested this finally - everything is OK now, thanks!

@gmarull
Copy link
Member Author

gmarull commented Aug 3, 2022

Hi @gmarull,

I've tested this finally - everything is OK now, thanks!

can you approve then?

@nashif nashif merged commit 83d73f6 into zephyrproject-rtos:main Aug 3, 2022
@gmarull gmarull deleted the arc-soc-cleanup branch August 3, 2022 11:48
@gmarull gmarull mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejlmand tejlmand tejlmand left review comments

@nashif nashif nashif approved these changes

@ruuddw ruuddw ruuddw approved these changes

@evgeniy-paltsev evgeniy-paltsev evgeniy-paltsev approved these changes

@stephanosio stephanosio stephanosio approved these changes

@dcpleung dcpleung Awaiting requested review from dcpleung dcpleung is a code owner

@galak galak Awaiting requested review from galak

@abrodkin abrodkin Awaiting requested review from abrodkin

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@mnkp mnkp Awaiting requested review from mnkp

@ceolin ceolin Awaiting requested review from ceolin

@KangJianX KangJianX Awaiting requested review from KangJianX

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@peter-mitsis peter-mitsis Awaiting requested review from peter-mitsis

@teburd teburd Awaiting requested review from teburd

@cfriedt cfriedt Awaiting requested review from cfriedt

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@andyross andyross Awaiting requested review from andyross

Assignees

@ruuddw ruuddw

Labels
area: ARC ARC Architecture area: Devicetree area: GPIO area: I2C area: Kernel area: SPI SPI bus area: Timer Timer platform: Synopsys Synopsys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gmarull @evgeniy-paltsev @ruuddw @nashif @andyross @tejlmand @stephanosio @zephyrbot