boards: arm: Add support for NUCLEO_F091RC board #4493
Conversation
dbkinder
left a comment
dbkinder
left a comment
There was a problem hiding this comment.
add a comma and we're good.
There was a problem hiding this comment.
add the comma before "and":
power consumption, and features.
galak
left a comment
galak
left a comment
There was a problem hiding this comment.
some minor things to fix. Can you add a bit more detail in the commit message body.
drivers/serial/uart_stm32.c
Outdated
There was a problem hiding this comment.
How about we do #ifndef CONFIG_SOC_SERIES_STM32F0X. So we don't have to keep updating the list for each F0 SoC that gets supported.
There was a problem hiding this comment.
Done.
Actually FOx SoCs support the LIN break detection but the driver does not support it currently.
There was a problem hiding this comment.
This should be in the SoC patch
There was a problem hiding this comment.
You could also make it generic to STM32F091XX (rename to Kconfig.defconfig.stm32f091xx)
There was a problem hiding this comment.
Moved to soc patch.
Did not make it generic. IMHO this should be done in a separate pull request. I plan to do that when I adapt zephyr for my custom made F091xB board.
There was a problem hiding this comment.
Board's DT file configures UART_1 to pins PB6/7. Could you update the mapping here?
dts/arm/nucleo_f091rc.dts
Outdated
There was a problem hiding this comment.
USART1 is disabled. We should better remove 'status = "ok";'.
dts/arm/st/mem.h
Outdated
There was a problem hiding this comment.
While this is correct, I wonder why STM32F091XB is added here.
Please remove as 091XB is not supported otherwise
There was a problem hiding this comment.
You could also make it generic to STM32F091XX (rename to Kconfig.defconfig.stm32f091xx)
boards/arm/nucleo_f091rc/pinmux.c
Outdated
arch/arm/soc/st_stm32/stm32f0/soc.h
Outdated
There was a problem hiding this comment.
You may enable I2C in a separate commit.
b0661
force-pushed
the
nucleo_f091rc
branch
2 times, most recently
from
b84c06f to
9b7b3f0
Compare
|
@galak do you have other comments to this PR ? |
Support the ST STM32F091xC SoC. Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
Support the USARTs of the ST STM32F091xx SoC. Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
Support the ST STM32 Nucleo-64 development board with STM32F091RC SoC. Signed-off-by: Bobby Noelte <b0661n0e17e@gmail.com>
6 participants
boards: arm: Add support for NUCLEO_F091RC board
Signed-off-by: Bobby Noelte b0661n0e17e@gmail.com