net: sockets: Use struct timeval provided by libc #41916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of redefining own `struct zsock_timeval` type at the socket layer, use a standard type provided by libc. This prevents the compliation errors when application includes both, `net/socket.h` and standard C header defining `struct timeval` (sys/time.h). Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
|
Solves my issue #41503. |
pdgendt
approved these changes
Jan 20, 2022
mniestroj
approved these changes
Jan 21, 2022
|
@rlubos should this be backported? |
|
I don't think we need to backport this, the error can be easily avoided by reordering headers. |
Wouldn't backporting this make it easier? |
|
Well, if you insist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of redefining own
struct zsock_timevaltype at the socketlayer, use a standard type provided by libc. This prevents the
compliation errors when application includes both,
net/socket.handstandard C header defining
struct timeval(sys/time.h).Fixes #41503
Signed-off-by: Robert Lubos robert.lubos@nordicsemi.no