drivers: ethernet: eth_stm32_hal.c: enable IRQ at the end of iface init #35218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
reviewed
May 12, 2021
ABOSTM
force-pushed
the
ETH_IRQ_ENABLE_TOO_EARLY
branch
from
78217bc to
558025b
Compare
jukkar
approved these changes
May 12, 2021
ABOSTM
force-pushed
the
ETH_IRQ_ENABLE_TOO_EARLY
branch
from
558025b to
c31c4f9
Compare
Member
|
^^@jonasn-ge |
Contributor
KozhinovAlexander
left a comment
KozhinovAlexander
left a comment
There was a problem hiding this comment.
@ABOSTM Thank you for your PR and testing it. Please take a look at my suggestions. I hope, they can be helpful. Otherwise LGTM.
|
This helps my use-case, see comment in #32771. Tested on STM32F427 with auto-neg disabled. |
lochej
approved these changes
May 14, 2021
lochej
approved these changes
May 14, 2021
Contributor
lochej
left a comment
lochej
left a comment
There was a problem hiding this comment.
LGTM, tested on F767ZI with dumb_http_server 👍
This avoid IRQ to be handle before iface init is finished (especially before iface address is set) Fixes zephyrproject-rtos#32771 Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
ETH_IRQ_ENABLE_TOO_EARLY
branch
from
c31c4f9 to
653b329
Compare
erwango
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drivers: ethernet: eth_stm32_hal.c: enable IRQ at the end of iface init
This avoid IRQ to be handle before iface init is finished
(especially before iface address is set)
Fixes #32771