drivers: wifi: esp_at: rename driver from esp #34921
Conversation
mniestroj
requested review from
MaureenHelm,
galak,
jukkar,
nandojve,
pfalcon and
tbursztyka
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
mniestroj
force-pushed
the
wifi-esp-rename-to-esp-at
branch
3 times, most recently
from
93269fa to
253890b
Compare
galak
left a comment
galak
left a comment
There was a problem hiding this comment.
Generally looks good. Would suggest updating the Help/Kconfig text to clarify 'AT command' support.
mniestroj
force-pushed
the
wifi-esp-rename-to-esp-at
branch
from
253890b to
ce05b8c
Compare
Recently WiFi ESP32 driver (utilizing WiFi radio in ESP32 SoC) was introduced into drivers/wifi/esp32/ and it already caused confusion as there was existing drivers/wifi/esp/ directory for ESP-AT driver (utilizing external WiFi chip, by communicating using AT commands from any serial capable platform). So question has arisen whether it is good to merge both, while they are totally different drivers. Rename ESP-AT driver to be placed in drivers/wifi/esp_at/, so that it is easier to figure out difference between "esp32" and "esp_at" just by looking at driver name. Rename also DT compatible and all Kconfig options for the same reason. Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
mniestroj
force-pushed
the
wifi-esp-rename-to-esp-at
branch
from
ce05b8c to
715a0af
Compare
|
@mniestroj doesn't need to be in this PR, but we should add a comment in the release notes about this change. |
| menuconfig WIFI_ESP | ||
| bool "Espressif ESP8266 and ESP32 support" | ||
| menuconfig WIFI_ESP_AT | ||
| bool "Espressif AT Command support" |
There was a problem hiding this comment.
Is this clear enough description? I'm not sure. Possible ideas: Espressif devices via AT commands, Espressif devices via serial, Espressif ESP8266/ESP32 via AT commands, etc.
There was a problem hiding this comment.
The idea behind Espressif AT Command ... was that this WiFi driver implements/utilizes AT commands defined by Espressif. So more like "Espressif's AT command interface". With proposed Espressif devices via ... it suggests that only Espressif devices could be used. This is true for now, but in theory someone could implement exactly the same functionality on other vendor's WiFi chip, but just conforming to the same AT commands as esp-at repository does. In the end, I don't have strong preference here.
9 participants
Recently WiFi ESP32 driver was introduced into
drivers/wifi/esp32/ (utilizing WiFi radio in SoC) and it already caused
confusion as there was existing drivers/wifi/esp/ directory for ESP-AT
driver (utilizing external WiFi chip, by communicating using AT
commands). So question has arisen whether it is good to merge both,
while they are totally different drivers.
Rename ESP-AT driver to be placed in drivers/wifi/esp_at/, so that it is
easier to figure out difference between "esp32" and "esp_at" just by
looking at driver name. Rename also DT compatible and all Kconfig
options for the same reason.
See discussion in #32081 with this proposal.