lora: power consumption fixes #31572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mani-Sadhasivam
requested changes
Jan 31, 2021
added 3 commits
January 31, 2021 19:46
Update the global state of the modem on calls to `SX126xReset` and `SX126xWakeup`. This stops `SX126xCheckDeviceReady` sending spurious SPI commands on every transieve before `SX126xSetOperatingMode` is called. Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
Disable the DIO1 interrupt when the sx126x modem is in sleep mode. On nRF hardware, this lets the `GPIOTE` hardware be switched off, saving 15uA. Fixes #31569. Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
Move the public network request command from the end of `lorawan_start` to the start of `lorawan_join`. This MAC command interacts with the radio driver, bringing it out of sleep mode, and doesn't put it back. The public network setting is only needed when joining a network, and `lorawan_start` can be called well before `lorawan_join`. By moving the command we save ~600uA before joining (for sx1262). Signed-off-by: Jordan Yates <jordan.yates@data61.csiro.au>
mniestroj
reviewed
Jan 31, 2021
mniestroj
approved these changes
Feb 3, 2021
Member
|
@Mani-Sadhasivam can you please re-review? |
Mani-Sadhasivam
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two causes of excess power consumption.
The initial commit keeps the drivers power state variable in sync with the actual state, to ensure the wakeup function is only called once per exit from sleep.
The second commit disables the DIO1 interrupt when the modem is in sleep mode, fixes #31569
The third commit moves when the LoRaWAN MAC layer is notified of the public network state.
The new location in
lorawan_joinis the more correct location for the command, and reduces power consumption whenlorawan_startandlorawan_joinare separated in time.