Move power subsystem to new power states #31273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceolin
added
area: Power Management
DNM
ceolin
requested review from
FRASTM,
MaureenHelm,
MulinChao,
albertofloyd,
andrewboie,
andyross,
bwitherspoon,
carlescufi,
erwango,
franciscomunoz,
galak,
ioannisg,
nashif,
scottwcpg,
tbursztyka and
wentongwu
as code owners
github-actions
bot
added
area: API
nashif
reviewed
Jan 13, 2021
samples/boards/mec15xxevb_assy6853/power_management/src/power_mgmt.c
Outdated
Show resolved
Hide resolved
ceolin
changed the title
nashif
approved these changes
Jan 22, 2021
pabigot
reviewed
Jan 22, 2021
Contributor
pabigot
left a comment
pabigot
left a comment
There was a problem hiding this comment.
I don't think this is quite right yet but I also don't think we know enough to say what's right, so I have no objections or changes requested. Will wait until CI passes for a final check before approving.
@erwango please revisit your nak.
Contributor
There was a problem hiding this comment.
This doesn't seem to match #31162 (comment), but I guess that can be fixed later.
Member
Author
There was a problem hiding this comment.
The comment was not super conclusive and was not clear about EM2 and EM3, also right now is not clear how to distinguish between them, so just keep this way for clarity sake.
added 8 commits
January 21, 2021 23:37
Migrate the whole pm subsystem to use new power states information from power_state.h and get states and residency properties from device tree. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Remove conditionals (PM_DEEP_SLEEP_STATES and PM_SLEEP_STATES) from power management code. Now these features are always available when power management is enabled. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Power management require stubs for pm_power_state_set() and pm_power_state_exit_post_ops(). Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Residency time and power states are defined using device tree now. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
There are platforms that have multiple states that maps to a specific Zephyr power state. To accommodate this sort of situation this commit adds an additional property to a power state that can be used by the platform. The power state now consists of two properties, a category and a substate-id. The former property is the current power state. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Change subsystem to use struct pm_state with substate-id instead of using only the power state category. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
Power management requires core interrupt handling. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This targets was previously enabling PM but the code was doing nothing because the logic was under an unsatisfied ifdef condition. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
pabigot
approved these changes
Jan 22, 2021
Contributor
There was a problem hiding this comment.
Remaining build failures in https://buildkite.com/zephyr/zephyr/builds/18862 don't seem related to anything I'm concerned with.
Later: They're not: see #31530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing: