tests: mem_protect: exclude nRF5340 DK from the gap filling test #30559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
requested review from
andrewboie,
andyross and
nashif
as code owners
github-actions
bot
added
area: Kernel
area: Tests
PerMac
requested changes
Dec 10, 2020
Member
PerMac
left a comment
PerMac
left a comment
There was a problem hiding this comment.
I think you were a bit too generous with copy pasting ;) Now the tests in this yaml will have the same names/ids as the ones in userspace, and it shouldn't be the case, so probably you'll have to remove .userspace from the names
Modify test .yaml file, to allow the .gap_filling test variant to execute only on cortex-m33 platforms with sufficient number of MPU regions. Copy pasting the configuration from mem_protect/userspace test. Signed-off-by: Ioannis Glaropoulos <Ioannis.Glaropoulos@nordicsemi.no>
ioannisg
force-pushed
the
tests_mem_protect_exclude_nrf5340_dk
branch
from
48c58b9 to
b5a597b
Compare
PerMac
approved these changes
Dec 10, 2020
ioannisg
added
the
Trivial
carlescufi
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify test .yaml file, to allow the .gap_filling test
variant to execute only on cortex-m33 platforms with
sufficient number of MPU regions. Copy pasting the
configuration from mem_protect/userspace test.
Signed-off-by: Ioannis Glaropoulos Ioannis.Glaropoulos@nordicsemi.no
Fixes #30253