Bluetooth: Mesh: Fixes LPN poll timeout gradually grow #30474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingaoM
requested review from
Vudentz,
jhedberg,
joerchan and
trond-snekvik
as code owners
trond-snekvik
suggested changes
Dec 7, 2020
Contributor
trond-snekvik
left a comment
trond-snekvik
left a comment
There was a problem hiding this comment.
Could you please describe the problem this commit is solving in the commit message?
trond-snekvik
approved these changes
Dec 7, 2020
Member
|
Is this a regression or has it always been broken? If it's a regression it would be good to reference the commit that broke it in the commit message. |
Contributor
|
According to the linked bug report this is a regression since: 3b4d58a |
`POLL_TIMEOUT_MAX` should use `CONFIG_BT_MESH_LPN_POLL_TIMEOUT` instead of `CONFIG_BT_MESH_LPN_INIT_POLL_TIMEOUT`. The described algorithm to grow the poll timeout implemented in function poll_timeout does not work with this implementation. It's a regression in 3b4d58a Bluetooth: Mesh: optimize performance for lpn node Fixes: #30338 Signed-off-by: Lingao Meng <menglingao@xiaomi.com>
jhedberg
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POLL_TIMEOUT_MAXshould useCONFIG_BT_MESH_LPN_POLL_TIMEOUTinstead of
CONFIG_BT_MESH_LPN_INIT_POLL_TIMEOUT. The describedalgorithm to grow the poll timeout implemented in function
poll_timeout does not work with this implementation.
It's a regression in 3b4d58a
Bluetooth: Mesh: optimize performance for lpn node
Fixes: #30338
Signed-off-by: Lingao Meng menglingao@xiaomi.com