Skip to content

Conversation

@ygubin
Copy link

@ygubin ygubin commented Nov 4, 2020

Dereferencing wrong pointer leads to wrong pin irq enable/disable during interrupt handling.

Fixes #29721

Signed-off-by: Yurii Gubin y.gubin@gmail.com

@ygubin ygubin requested a review from avisconti as a code owner November 4, 2020 21:00
@ygubin ygubin force-pushed the 29721_fix_lsm6dsl_interrupt_handling branch from 9f35f78 to 0c0f657 Compare November 4, 2020 21:19
Obtaining irq_pin from dev leads to disabling interrupts
on unpredictable pin, as dev points to GPIO, not LSM6DSL.

Fixes zephyrproject-rtos#29721

Signed-off-by: Yurii Gubin <y.gubin@gmail.com>
@ygubin ygubin force-pushed the 29721_fix_lsm6dsl_interrupt_handling branch from 0c0f657 to 3dd0d82 Compare November 4, 2020 21:23
Copy link
Contributor

@avisconti avisconti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm too busy!

@avisconti avisconti requested a review from MaureenHelm November 6, 2020 09:43
@MaureenHelm MaureenHelm merged commit f700d74 into zephyrproject-rtos:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

drivers/sensor/lsm6dsl: assertion/UB during interrupt handling

3 participants