Refactor the SX1276 driver to facilitate code reuse #25040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mani-Sadhasivam
requested changes
May 10, 2020
Mani-Sadhasivam
approved these changes
May 11, 2020
chrta
reviewed
May 18, 2020
chrta
approved these changes
May 19, 2020
Contributor
chrta
left a comment
chrta
left a comment
There was a problem hiding this comment.
LGTM. I have not tested this, but i think this is a good improvement.
Member
|
Needs rebase and switching to C99 types @andysan |
The implementation of the board support routines is shared between all LoRa drivers that use LoRaMAC-Node. Move them from the SX1276 implementation to a separate source file to facilitate reuse. Make this source file conditional on CONFIG_HAS_SEMTECH_RADIO_DRIVERS since it will be used by all LoRaMAC-Node-based drivers. Signed-off-by: Andreas Sandberg <andreas@sandberg.pp.se>
LoRa radios supported by LoRaMAC-Node have a lot of common functionality. Zephyr's LoRa implementation for the SX1276 uses LoRaMAC-Nodes Radio HAL to implement API functionality like send and recv. The exact same functionality will be used by the SX126x driver. Facilitate sharing by moving that to a separate source file. Signed-off-by: Andreas Sandberg <andreas@sandberg.pp.se>
Contributor
Author
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SX126x and the SX1276 share a significant amount of code. Refactor the current code to facilitate reuse.
Note: The CW API change is expected to go in together with the shell before this PR. The commit is included here as a "glue" commit.